Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23125] Support real time vehicle location indicator #171

Merged

Conversation

sg-jsonjuliane
Copy link
Contributor

@sg-jsonjuliane sg-jsonjuliane commented Jan 13, 2025

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • Added support for real time vehicle location
  • Added animation whenever the bus marker updates
  • Working fade mechanism for marker and pulse
  • Working real time indicator in the occupancy indicator in the list

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@sg-jsonjuliane sg-jsonjuliane force-pushed the feature/23125-support-real-time-vehicle-location branch from 2dc7f58 to 8485fe8 Compare January 16, 2025 12:09
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@sg-jsonjuliane sg-jsonjuliane merged commit e5633bc into develop Jan 20, 2025
1 check passed
@sg-jsonjuliane sg-jsonjuliane deleted the feature/23125-support-real-time-vehicle-location branch January 20, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants