[Error: ICON_INVALID] #74

Ammarlio · 2022-10-26T12:43:28Z

Platform

iOS
Android

Description
After Integrating and follow the same steps for Android, i am getting [Error: ICON_INVALID]. I did all the steps as the docs and all icons are valid. Anyway on IOS it works fine. Even if i am setting enable property to true in activity-alias for default icon, i am getting the same error.

To Reproduce
Steps to reproduce the behavior:

invoke changeIcon('blueicon');
getting the error message [Error: ICON_INVALID]

Screenshots
[Error: ICON_INVALID]

Device (please complete the following information):

Device: [Android A52s 5G]

Versions

react-native: [^0.68.2]
react-native-change-icon: [^4.0.0]

Code Snippet

<uses-permission android:name="android.permission.VIBRATE" />
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="com.google.android.apps.photos.permission.GOOGLE_PHOTOS" />

<application
    android:name=".MainApplication"
    android:allowBackup="false"
    android:icon="@mipmap/defaulticon"
    android:label="@string/app_name"
    android:roundIcon="@mipmap/defaulticon_round"
    android:supportsRtl="true"
    android:theme="@style/AppTheme">

    <receiver
        android:name=".widgets.summaryWidget.summaryWidget"
        android:exported="true">
        <intent-filter>
            <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
        </intent-filter>

        <meta-data
            android:name="android.appwidget.provider"
            android:resource="@xml/summary_widget_info" />
    </receiver>
    <receiver
        android:name=".widgets.performanceWidget.PerformanceWidget"
        android:exported="true">
        <intent-filter>
            <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
        </intent-filter>

        <meta-data
            android:name="android.appwidget.provider"
            android:resource="@xml/testdemo_widget_info" />
    </receiver>

    <activity
        android:name=".widgets.performanceWidget.WidgetActivity"
        android:exported="false">
        <intent-filter>
            <action android:name="android.appwidget.action.APPWIDGET_CONFIGURE" />
        </intent-filter>
    </activity>
    <activity
        android:name=".MainActivity"
        android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
        android:exported="true"
        android:label="@string/app_name"
        android:launchMode="singleTask"
        android:windowSoftInputMode="adjustPan">
    </activity>

    <activity-alias
        android:name="com.testdemo.MainActivitydefaulticon"
        android:enabled="false"
        android:exported="true"
        android:icon="@mipmap/defaulticon"
        android:roundIcon="@mipmap/defaulticon_round"
        android:targetActivity=".MainActivity">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity-alias>

    <activity-alias
        android:name="com.testdemo.MainActivityblueicon"
        android:enabled="false"
        android:exported="true"
        android:icon="@mipmap/blueicon"
        android:roundIcon="@mipmap/blueicon_round"
        android:targetActivity=".MainActivity">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity-alias>
</application>

The text was updated successfully, but these errors were encountered:

skb1129 · 2023-08-20T05:09:55Z

@Ammarlio please use v5 and try using the updated docs for the setup

mayyas-nakhli · 2023-09-01T09:24:53Z

@Ammarlio
I was facing the same issue, the solution was to pass package name into the ChangeIconPackage constructor in MainApplication.java file

 @Override
    protected List<ReactPackage> getPackages() {
      List<ReactPackage> result = new ArrayList<ReactPackage>();

      result.addAll(Arrays.<ReactPackage>asList(
      ...
         new ChangeIconPackage("com.your.package")
         ));
     }

P.S: In my project library linking in both iOS and Android is manual.

MandaliyaPruthvi · 2023-09-19T08:02:20Z

Hello @skb1129

I tried using your package and getting the same error on the PROD. When I tried to display system generated error to get more detail about the error, I got below error:
"
java.lang.SecurityException: Attempt to change component state; pid=5326, uid=10523, component=ComponentInfo{com.package-name/{com.package-name.MainActivityExpressShipColor}
"

@mayyas-nakhli I've tried your solution as well but that's also not working.

@skb1129 Also updated to V5 and got this error.

vimosan7 · 2023-10-02T14:36:49Z

Make sure your applicationId is correct in android/app/build.gradle. This mismatch can cause problems.

defaultConfig {
    applicationId "com.yourapplicationid"
    minSdkVersion rootProject.ext.minSdkVersion
    targetSdkVersion rootProject.ext.targetSdkVersion
    versionCode 1
    versionName "1.0"
    signingConfig signingConfigs.debug
    vectorDrawables.useSupportLibrary = true
}

MandaliyaPruthvi · 2023-10-02T15:22:29Z

Thanks for your response I'll have a look into it and get back to you if it helps or not.

…

On Mon, 2 Oct 2023, 8:07 pm vimosan7, ***@***.***> wrote: Make sure your applicationId is correct in android/app/build.gradle. This mismatch can cause problems. defaultConfig { applicationId "com.yourapplicationid" minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion versionCode 1 versionName "1.0" signingConfig signingConfigs.debug vectorDrawables.useSupportLibrary = true } — Reply to this email directly, view it on GitHub <#74 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7ZQYKGEW2RZRGU35EE23DX5LGQZAVCNFSM6AAAAAARO6TK3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGE2DCMRTGQ> . You are receiving this because you commented.Message ID: ***@***.***>

vikasrai1502 · 2023-12-08T08:16:17Z

I'm facing issues to make changes in AndroidManifest.xml, when I'm having .SplashActivity (react-native-splash-screen). I tried multiple permutation-combination but either app is crashing or getting [Error:ICON_INVALID]. Current AndroidManifest.xml code is below and getting [Error:ICON_INVALID] error.

Thanks

<activity
        android:name=".SplashActivity"
        android:theme="@style/AppTheme"
        android:label="@string/app_name"
        android:exported="true">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />
        </intent-filter>
      </activity>  
        <activity-alias 
            android:name="com.packagename.SplashActivityDefault"
            android:enabled="true"
            android:exported="true"
            android:icon="@mipmap/ic_launcher"
            android:roundIcon="@mipmap/ic_launcher"
            android:targetActivity=".SplashActivity">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
                <action android:name="android.intent.action.DOWNLOAD_COMPLETE"/>
            </intent-filter>
        </activity-alias>
        <activity-alias 
            android:name="com.packagename.SplashActivityXmas"
            android:enabled="false"
            android:exported="true"
            android:icon="@mipmap/ic_launcher_xmas"
            android:roundIcon="@mipmap/ic_launcher_xmas"
            android:targetActivity=".SplashActivity">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
                <action android:name="android.intent.action.DOWNLOAD_COMPLETE"/>
            </intent-filter>
        </activity-alias>
      <activity
        android:name=".MainActivity"
        android:label="@string/app_name"
        android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
        android:launchMode="singleTask"
        android:windowSoftInputMode="adjustResize"
        android:screenOrientation="portrait"
        android:theme="@style/AppTheme"
        android:exported="true">
          <intent-filter android:autoVerify="true">
              <action android:name="android.intent.action.VIEW"/>
              <category android:name="android.intent.category.DEFAULT"/>
              <category android:name="android.intent.category.BROWSABLE"/>
              <data android:scheme="http" />
              <data android:scheme="https" />
          </intent-filter>
      </activity>

yunuskucuk11 · 2024-01-31T13:22:46Z

I use more than one variant. These types of applications give this error because of the package name, how should we use it?

jalvarez930 · 2024-03-08T22:38:33Z

tions give this error because of the package name, how

Have the same error. Do you resolve it

n76i · 2024-03-12T16:22:42Z

tions give this error because of the package name, how

Have the same error. Do you resolve it

Hello, I have the same error too, here is something can fix it:

You have more than one variant, but you have only one package (com.example)
Open ChangeIconModule.java in node_modules and edit something:
Find final String activeClass = this.packageName + newIconName;
And update with your package: final String activeClass = "com.example.MainActivity" + newIconName;
Now it worked, create patch-package to use and wait update from lib owner

sheriffmarley · 2024-11-05T15:09:15Z

I use more than one variant. These types of applications give this error because of the package name, how should we use it?

Had the same issue, this is because if you define a flavor with an applicationId, the packageName would become:
com.example.myapp.dev
but we need
com.example.myapp

I could solve it by removing the flavor in ChangeIconModule.java on line 75
final String activeClass = this.packageName + ".MainActivity" + newIconName;

So i came up with this solution:

String activeClass = this.packageName + ".MainActivity" + newIconName;
        if (activeClass.contains(".dev.")) {
            activeClass = activeClass.replace(".dev.", ".");
        }

Guess we need a way to detect flavors properly so they can be removed.

marcosbotene · 2024-12-03T14:33:12Z

I use more than one variant. These types of applications give this error because of the package name, how should we use it?

Had the same issue, this is because if you define a flavor with an applicationId, the packageName would become: com.example.myapp.dev but we need com.example.myapp

I could solve it by removing the flavor in ChangeIconModule.java on line 75 final String activeClass = this.packageName + ".MainActivity" + newIconName;

So i came up with this solution:
String activeClass = this.packageName + ".MainActivity" + newIconName;
        if (activeClass.contains(".dev.")) {
            activeClass = activeClass.replace(".dev.", ".");
        }
Guess we need a way to detect flavors properly so they can be removed.

I tried this solution but it didn't work very well, my app duplicated on the device with different icons, at least I could see the library working (I have 3 different versions in my app, without this workaround I couldn't even see the library working), but it didn't solve my problem, unfortunately I was forced to stop the feature I was developing.

git-jr · 2024-12-06T20:15:19Z

For me, the solution was to remove the applicationId and leave just "MainActivityIconName":
Before:

        <activity-alias
            android:name="com.teste.MainActivity2"
            android:enabled="true"
            android:exported="true"...

After:

        <activity-alias
            android:name=".MainActivity2"
            android:enabled="true"
            android:exported="true"...

lucassms9 · 2024-12-09T18:58:34Z

@marcosbotene in Android the native behaviour is create two icons, keep the old one and create the new one.
if you want to avoid this behaviour, you have to use the COMPONENT_ENABLED_STATE_DISABLED params in the setComponentEnabledSetting method.

try do that in your ChangeIconModule.java:

 // display new icon
   activity.getPackageManager().setComponentEnabledSetting(
                    new ComponentName(this.packageName, activeClass),
                    PackageManager.COMPONENT_ENABLED_STATE_ENABLED,
                    PackageManager.DONT_KILL_APP);
 // hide old icon
            activity.getPackageManager().setComponentEnabledSetting(
                    new ComponentName(this.packageName, activeClassDefault),
                    PackageManager.COMPONENT_ENABLED_STATE_DISABLED,
                    PackageManager.DONT_KILL_APP);

git-jr · 2024-12-10T12:31:03Z

@lucassms9 Thank you so much for your help! Your solution worked perfectly and saved me a lot of time. I really appreciate your effort and support!

vikas-chhabra · 2024-12-16T20:32:52Z

Reason - Your app must have build variants due to which this.packageName get's combined with the build variant.
Example
Package Name - com.somepackage.app
Build Variant is - stage, prod
this.packageName - com.somepackage.app.stage

But to change the icon we don't need to combine the packagename with build variant so, for a temproary solution

open node_modules/react-native-change-icon/android/src/main/java/com/reactnativechangeicon/ChangeIconModule.java

// OLD
L75: final String activeClass = this.packageName + ".MainActivity" + newIconName;

// New
 final String activeClass = "com.somepackage.app" + ".MainActivity" + newIconName;

then run

npx patch-package react-native-change-icon

Ammarlio assigned skb1129 Oct 26, 2022

pwltr mentioned this issue Jun 26, 2024

Android refactor to handle activities not named "Main" #100

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Error: ICON_INVALID] #74

[Error: ICON_INVALID] #74

Ammarlio commented Oct 26, 2022 •

edited

Loading

skb1129 commented Aug 20, 2023

mayyas-nakhli commented Sep 1, 2023 •

edited

Loading

MandaliyaPruthvi commented Sep 19, 2023

vimosan7 commented Oct 2, 2023

MandaliyaPruthvi commented Oct 2, 2023 via email

vikasrai1502 commented Dec 8, 2023 •

edited

Loading

yunuskucuk11 commented Jan 31, 2024

jalvarez930 commented Mar 8, 2024

n76i commented Mar 12, 2024

sheriffmarley commented Nov 5, 2024 •

edited

Loading

marcosbotene commented Dec 3, 2024

git-jr commented Dec 6, 2024

lucassms9 commented Dec 9, 2024 •

edited

Loading

git-jr commented Dec 10, 2024

vikas-chhabra commented Dec 16, 2024

[Error: ICON_INVALID] #74

[Error: ICON_INVALID] #74

Comments

Ammarlio commented Oct 26, 2022 • edited Loading

skb1129 commented Aug 20, 2023

mayyas-nakhli commented Sep 1, 2023 • edited Loading

MandaliyaPruthvi commented Sep 19, 2023

vimosan7 commented Oct 2, 2023

MandaliyaPruthvi commented Oct 2, 2023 via email

vikasrai1502 commented Dec 8, 2023 • edited Loading

yunuskucuk11 commented Jan 31, 2024

jalvarez930 commented Mar 8, 2024

n76i commented Mar 12, 2024

sheriffmarley commented Nov 5, 2024 • edited Loading

marcosbotene commented Dec 3, 2024

git-jr commented Dec 6, 2024

lucassms9 commented Dec 9, 2024 • edited Loading

git-jr commented Dec 10, 2024

vikas-chhabra commented Dec 16, 2024

Ammarlio commented Oct 26, 2022 •

edited

Loading

mayyas-nakhli commented Sep 1, 2023 •

edited

Loading

vikasrai1502 commented Dec 8, 2023 •

edited

Loading

sheriffmarley commented Nov 5, 2024 •

edited

Loading

lucassms9 commented Dec 9, 2024 •

edited

Loading