Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate publishing development versions of the package #53

Open
vsbogd opened this issue Oct 15, 2018 · 6 comments
Open

Automate publishing development versions of the package #53

vsbogd opened this issue Oct 15, 2018 · 6 comments
Labels

Comments

@vsbogd
Copy link
Member

vsbogd commented Oct 15, 2018

This issue is result of discussion in PR #51 (see PR singnet/snet-cli#76 for previous related change).

Solution proposed in PR #51 requires additional compilation and package building when platform-contracts package is deployed as dependency.

Solution proposed in PR singnet/snet-cli#76 requires developing dev dependency installation script and .circleci scenarios modification for each repo which uses platform-contracts.

So we need to design and develop packaging solution which doesn't have these disadvantages or agree with one of the approaches above.

@vsbogd
Copy link
Member Author

vsbogd commented Oct 16, 2018

One possible way is to publish new github release each time when we need new version globally.

It can be published manually for instance using some script. Or we can add publishing step to the circleci script which handlea changes in master branch. The only problem I see is authentication.

@vsbogd
Copy link
Member Author

vsbogd commented Oct 17, 2018

I have added first development release for platform-contracts manuall release v0.2.2

Commands to create release tarball:

VERSION=0.2.2
npm install
npm run compile
npm run package-npm
cd build
mv npm-module singularitynet-platform-contracts
tar czf singularitynet-platform-contracts-${VERSION}.tgz singularitynet-platform-contracts

@astroseger
Copy link
Collaborator

Should we close it?

@vsbogd
Copy link
Member Author

vsbogd commented Oct 23, 2018

I would say we should automate release publishing first then we can close it.

@astroseger
Copy link
Collaborator

Now snet-cli and daemon use development releases in order to get ABI of contracts. But it should be noted that snet-cli gets address of Registry and AgentFactory from networks/*.json files from npm-package. Which is might be not optimal for tests...

@vsbogd
Copy link
Member Author

vsbogd commented Oct 26, 2018

We can remove all network addresses except main and testnet from published versions.

@raamb raamb added the beta label Nov 15, 2018
@vsbogd vsbogd changed the title Find a proper way to publish development versions of the package Automate publishing development versions of the package Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants