-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate publishing development versions of the package #53
Comments
One possible way is to publish new github release each time when we need new version globally. It can be published manually for instance using some script. Or we can add publishing step to the circleci script which handlea changes in master branch. The only problem I see is authentication. |
I have added first development release for platform-contracts manuall release v0.2.2 Commands to create release tarball: VERSION=0.2.2
npm install
npm run compile
npm run package-npm
cd build
mv npm-module singularitynet-platform-contracts
tar czf singularitynet-platform-contracts-${VERSION}.tgz singularitynet-platform-contracts |
Should we close it? |
I would say we should automate release publishing first then we can close it. |
Now snet-cli and daemon use development releases in order to get ABI of contracts. But it should be noted that snet-cli gets address of Registry and AgentFactory from networks/*.json files from npm-package. Which is might be not optimal for tests... |
We can remove all network addresses except main and testnet from published versions. |
This issue is result of discussion in PR #51 (see PR singnet/snet-cli#76 for previous related change).
Solution proposed in PR #51 requires additional compilation and package building when
platform-contracts
package is deployed as dependency.Solution proposed in PR singnet/snet-cli#76 requires developing dev dependency installation script and .circleci scenarios modification for each repo which uses
platform-contracts
.So we need to design and develop packaging solution which doesn't have these disadvantages or agree with one of the approaches above.
The text was updated successfully, but these errors were encountered: