Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HookWebpackError: HMR is not implemented for module chunk format yet #425

Closed
juliogc opened this issue Nov 23, 2024 · 4 comments · Fixed by #426
Closed

HookWebpackError: HMR is not implemented for module chunk format yet #425

juliogc opened this issue Nov 23, 2024 · 4 comments · Fixed by #426

Comments

@juliogc
Copy link

juliogc commented Nov 23, 2024

Hi, @joeldenning, it's me again! 😅

I'm following up with the build I mentioned in the #421 issue, but now I get a new issue.
I recreated the whole stack using [email protected] and everything went fine with the single-spa stack, but now I'm facing a new error mentioned in this issue title: HookWebpackError: HMR is not implemented for module chunk format yet

I understand that it's a webpack related issue but the docs don't make it clear how can I proceed with it and developing with HMR will be a pain 😕

Should I get rid of the single-spa/import-map-injector and move to SystemJS or there is any workaround to keep working with the libraryTarget: 'module'?

@joeldenning
Copy link
Member

See related webpack/webpack#17636

@joeldenning
Copy link
Member

joeldenning commented Nov 24, 2024

Fix released in [email protected]

@juliogc
Copy link
Author

juliogc commented Nov 25, 2024

Fix released in [email protected]

@joeldenning I appreciate the fix!

To clarify, if I want to keep HMR, should I continue using SystemJS?
Is there more information about the outputSystemJS flag? I found some info at CHANGELOG#6.0.0 but I would like to understand more about the effects of using it

@joeldenning
Copy link
Member

To clarify, if I want to keep HMR, should I continue using SystemJS?

Until webpack supports HMR for esm, yes

Is there more information about the outputSystemJS flag? I found some info at CHANGELOG#6.0.0 but I would like to understand more about the effects of using it

See

libraryTarget: opts.outputSystemJS ? "system" : "module",
and #433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants