Electron 30 support

[staniel359]

Hello.

Recently Electron API has changed, deprecating BrowserView and introducing WebContentsView instead.
But it can be used only with BaseWindow instead of BrowserWindow.

And now download(<BaseWindow>, url, options) gives me an error:

Are you planning to add Electron 30 compatibility?

[sindresorhus]

I believe this must be fixed in Electron. They need to support WebContentsView in BrowserWindow.fromWebContents. Then it will just work here. I recommend opening an issue on Electron.

[staniel359]

@sindresorhus But could you add a support for BaseWindow as well?

[sindresorhus]

I guess what's missing then is a BaseWindow.fromWebContents() method. Because this package receives a WebContents when a download is about to start, and it has to be able to convert that back to a window.

[staniel359]

@sindresorhus So you'll add it after Electron implements it?

[sindresorhus]

Yes

[staniel359]

@sindresorhus Okay, thanks.