Title with colon

[hemanth]

curl 'https://www.youtube.com/watch?v=ci0Pihl2zXY' -s | article-title

Results in:

#Edit2014

Commenting out this RE in the code, gives the right result that being Wikipedia: #Edit2014

//cc @sindresorhus

[hemanth]

@sindresorhus Meow :) ?

[sindresorhus]

Don't have time to look into this right now, but looks like I need to give higher priority to the last part of the title.

PR welcome in form of a fix or even just a failing test-case.

[hemanth]

👍

[icyflame]

@hemanth

I have done some work on this.

I have basically added two test cases.

One of them uses the node-curl package, and curls the page from Youtube and then finds the title. This returns an appropriate response. (Wikipedia: Edit14)

The second test is using a fixture. I have stored the HTML in a new fixture file, and then run the same test using a fixture. Surprisingly, this returns the result #Edit14 )

I am not able to figure out why the two differing results are found.

Find my new tests at: https://github.com/icyflame/article-title/blob/add-tests-for-titles-with-colon/test.js#L23

Output of the new test:

The one test that passes is the one which curls the youtube HTML.

cc: @sindresorhus

[astoilkov]

I am seeing a lot of incorrect results when using article-title on YouTube. Example:

• curl https://www.youtube.com/watch\?v\=aJOTlE1K90k | npx article-title-cli gives Maroon 5 instead of Maroon 5 - Girls Like You ft. Cardi B

I think two things can be done the docTitle stripping could be improved. Second, a new logic could be added where if you have only one h1 tag on the page this tag is considered the title.

[astoilkov]

@sindresorhus If you agree with the new logic regarding only one h1 on the page I can implement it and send a pull request.

[sindresorhus]

Yup. I agree. PR welcome :)