Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 docker image no longer available #1566

Open
1 task done
KennethWussmann opened this issue Feb 9, 2023 · 14 comments
Open
1 task done

arm64 docker image no longer available #1566

KennethWussmann opened this issue Feb 9, 2023 · 14 comments

Comments

@KennethWussmann
Copy link

Prerequisites

  • I have searched open and closed issues to make sure that the bug has not yet been reported.

Bug report

Describe the bug
The docker image simplelogin/app published to docker hub used to support the arm64 arch. For example this one month old image simplelogin/[email protected]

The successor simplelogin/app-ci is not multi-arch and only supports amd64.

Expected behavior
Because simplelogin/app does not appear to be updated anymore, I would expect that the successor simplelogin/app-ci supports arm64 arch just like the previous image did.

Additional context
A multi-arch build is missing here: https://github.com/simple-login/app/blob/master/.github/workflows/main.yml#L151-L156

Thank you

@nguyenkims
Copy link
Contributor

@KennethWussmann the simplelogin/app-ci is only used for our SaaS product (simplelogin.io) and we don't use ARM in production.

@KennethWussmann
Copy link
Author

@nguyenkims I see. I just hoped that maybe I could use it for testing my API client, but understandable if this is currently not a priority.
Thanks for checking.

@Slevin90
Copy link

For my self-hosted SimpleLogin instance I use a raspberrypi. 4.6.4-beta is running good for last few months.
I'd also like to see updates for arm64, helping the self-hosted people

@Slevin90
Copy link

Slevin90 commented May 21, 2023

Additional info:

@nguyenkims already had arm builds working before with help of @Metabaron1 (who has an 4.22.5 version online at hub.docker.com/r/metabaron/app)
#270

Seems like new versions haven't been made for https://hub.docker.com/r/simplelogin/app/ ( most recent is 4.6.5-beta)
and it isn't enabled for https://hub.docker.com/r/simplelogin/app-ci/ (on v.4.28.2)

@Metabaron1
Copy link

Metabaron1 commented May 21, 2023

Hi
Indeed I'm still running on arm64. So I built and pushed 4.22.5 just to try out, but I'm using 4.6.5-beta as is recommended version for self hosting.
I didn't noticed bug with beta version, and as I only have basic use, I don't really need app-ci new features ;)

@Slevin90
Copy link

I'm not looking for features, but having an up to date setup is also a security item to keep in mind.

@Metabaron1
Copy link

I do not rely on app security, I monitor all network connections.
But indeed, security is a good reason to use app-ci if you only rely on application.
Are you unable to build your own arm62 image on your raspberrypi?

@Slevin90
Copy link

Are you unable to build your own arm62 image on your raspberrypi?

I don't know how to build. Prefer it's build by the owner, this could be one thustworthy channel for all arm64 users

@Metabaron1
Copy link

Metabaron1 commented May 23, 2023

Best thustworthy channel is your own built one ;)
Here is how to build 4.28.2:

wget https://github.com/simple-login/app/archive/refs/tags/v4.28.2.zip
unzip v4.28.2.zip
docker build --tag app:4.28.2 app-4.28.2

...
should end up with "Successfully tagged app:4.28.2"

docker image ls app:4.28.2
should list : "app 4.28.2 ... About a minute ago 1.58GB"

Now when referencing sl-app image in docker command or docker-compose file, just replace official image "simplelogin/app:x.x.x" with your own local built image "app:4.28.2"

Edit: you have to build it on the raspberry to produce arm64 image. It's possible to build arm64 on intel platform as cross-platform build but it's a much more complex process, so just do it on your raspberry ;)

enjoy!

@Slevin90
Copy link

Slevin90 commented May 31, 2023

building 4.28.2 for arm64v8 worked (odroid-m1) . https://hub.docker.com/r/slevin1/app

updated database, like the update instructions ( Note: use alembic upgrade head in stead of flask db upgrade found in #1205 (comment) and #916 (comment))

had some problems with critical crash, manually increased the timeout in the sl-app-container from 15 to 45
gunicorn wsgi:app -b 0.0.0.0:7777 -w 2 --timeout 45

testing-environment works so far.

@martadams89
Copy link
Contributor

Should be resolved with #2056

@ctrl-i
Copy link

ctrl-i commented Nov 7, 2024

@martadams89 They seem to have stopped again. The latest published version on docker hub seems to be v4.53.0

@martadams89
Copy link
Contributor

martadams89 commented Nov 7, 2024

Edit: I was running my container from the wrong folder, turns out it works!

I forked it and added amd64 back into the workflow and made a build here - https://hub.docker.com/layers/martadams89/sl-app/master/images/sha256-a02ed25e8f9c8f7c2d2cf8f538be64dff1b19cf938bab70f7011de7fa39ca511?context=repo

I've done a quick test and it appears to work, so I've made a PR here - #2310 - to get it merged back.. thanks @ctrl-i for letting me know :)

@martadams89
Copy link
Contributor

I've set up my workflow to auto merge changes from the main repo to my fork, and a workflow to run weekly to dump an arm image.

@ctrl-i - this should hopefully keep you going until official arm builds are back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants