Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facets should not execute for ?shape=array|object #263

Closed
simonw opened this issue May 16, 2018 · 3 comments
Closed

Facets should not execute for ?shape=array|object #263

simonw opened this issue May 16, 2018 · 3 comments

Comments

@simonw
Copy link
Owner

simonw commented May 16, 2018

Split off from #255 - there's no point executing the facet SQL for the ?_shape=array and ?_shape=object API responses.
@simonw
Copy link
Owner Author

simonw commented May 16, 2018

The underlying mechanics for the _extras mechanism described in #262 may help with this.

@simonw simonw added this to the Next release milestone Jul 24, 2018
@simonw simonw removed this from the Next release milestone May 13, 2019
@simonw
Copy link
Owner Author

simonw commented Nov 30, 2020

Fixing this would unblock this issue for switching datasette-graphql to using datasette.client internally: simonw/datasette-graphql#61

This was referenced May 29, 2021
Closed
Closed
@simonw
Copy link
Owner Author

simonw commented Jun 1, 2021

This is a lot easier to implement now that we have a ?_nofacet=1 option from #1350.

@simonw simonw closed this as completed in 0539bf0 Jun 2, 2021
simonw added a commit that referenced this issue Jun 2, 2021
@simonw
Don't execute facets/counts for _shape=array or object, closes #263
82b938e
simonw added a commit that referenced this issue Jun 5, 2021
@simonw
Release 0.57
58746d3 
Refs #263, #615, #619, #1238, #1257, #1305, #1308, #1320, #1332, #1337, #1349, #1353, #1359, #1360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw