Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Direct module exposes way too much #62

Open
treeowl opened this issue Jul 5, 2018 · 1 comment
Open

The Direct module exposes way too much #62

treeowl opened this issue Jul 5, 2018 · 1 comment

Comments

@treeowl
Copy link
Contributor

treeowl commented Jul 5, 2018

I think it's pretty weird that Direct.Par derives a MonadReader Sched instance. It's also pretty weird that Direct exposes the Sched type despite not offering any documentation of it or any functions for working with it. I think it probably makes sense to remove that instance and require users to import DirectInternal to get the Sched type.
@simonmar
Copy link
Owner

Agreed, and I definitely support efforts to clean up and document the API here.

@treeowl treeowl mentioned this issue Jul 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmar @treeowl