Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom in/out inconsistently not respected until restart #7122

Open
2 tasks done
seansfkelley opened this issue Dec 20, 2024 · 1 comment
Open
2 tasks done

zoom in/out inconsistently not respected until restart #7122

seansfkelley opened this issue Dec 20, 2024 · 1 comment

Comments

@seansfkelley
Copy link

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

After upgrading to 7.36.1 this morning, zooming in/out is not always respected immediately. I cannot identify a pattern to when it does or does not happen, but it is easily reproduced when mashing zoom controls/changing window focus/changing desktop spaces/reopening windows.

I noticed after the update today that Signal restarted into a very zoomed-in level.

The accumulated zoom changes from attempting to zoom are always applied when Signal is restarted, meaning it may start in a different zoom level than when it quit.

Steps to reproduce

No single reproduction. Here's what I do in the video below:

  1. Open Signal
  2. Zoom works as expected
  3. Close Signal window (but don't quit Signal) and re-show it
  4. Zoom no longer works
  5. Quit Signal entirely and reopen it; notice that zoom level has changed from step 4
  6. Zoom still does not work
  7. Switch to another desktop, click on it to ensure focus change, then switch back to Signal
  8. Zoom works (and it skips a couple levels to catch up with zooms from step 6)

Expected result

Zoom controls are always respected immediately.

Actual result

Zoom changes are only respected sometimes, and eventually always applied when Signal is restarted.

Screenshots

Sorry for the poor quality. I had to compress it a lot to get under the GitHub file size limit.

Screen.Recording.2024-12-20.at.11.22.17-00.01.13.874-00.01.48.177.compressed.mov

Signal version

7.36.1

Operating system

macOS 15.0

Version of Signal on your phone

No response

Link to debug log

Note these logs are for a slightly different reproduction than shown in the video because I didn't keep that one. In this, I had zoom working, then closed the window and re-showed it, and it stopped working.

https://debuglogs.org/desktop/7.36.1/3056be694aa36ac5ef746f5b2395952937c91ef9fa1efc2c1c7303fddfb2476c.gz

@indutny-signal
Copy link
Contributor

Thank you for reporting this! This is likely an Electron bug, but we'll take a look to make sure we didn't miss anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants