feat: validate undeclared SigMF extensions in metadata #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate Extension Declarations in SigMF Files
Issue
Extensions used in SigMF metadata must be declared in the global
core:extensions
field, but the validator wasn't checking for undeclared extensions.Changes
Added validation to ensure all extension namespaces used in the metadata are properly declared in
global:core:extensions
. The validator now:global:core:extensions
Example
This will now fail validation:
{
"global": {
"core:datatype": "cf32_le",
"core:version": "1.0.0"
},
"captures": [{
"core:sample_start": 0,
"foo:some_field": 123 # Using undeclared 'foo' extension
}]
}
To fix, declare the extension:
{
"global": {
"core:datatype": "cf32_le",
"core:version": "1.0.0",
"core:extensions": [{
"name": "foo",
"version": "1.0.0",
"optional": true
}]
},
"captures": [{
"core:sample_start": 0,
"foo:some_field": 123 # Now properly declared
}]
}
Testing
Related Issues
Implements feature request from monthly SigMF call to validate extension declarations as in issue and closes #103