Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package.json exports #575

Closed
patroza opened this issue Nov 16, 2023 · 3 comments
Closed

fix package.json exports #575

patroza opened this issue Nov 16, 2023 · 3 comments
Labels
bug A bug that needs to be resolved closed-by-bot Closed by automation needs-reproduction Action needed: A valid reproduction of the issue needs to be added

Comments

@patroza
Copy link

patroza commented Nov 16, 2023

the package.json exports are missing a types entry:

  "exports": {
    ".": {
      "import": "./dist/module.mjs",
      "require": "./dist/module.cjs",
      "types": "./dist/module.d.ts" // missing
    }
  },

this causes no types to load for people using tsconfig moduleResolution set to Node16, NodeNext or bundler.

@phoenix-ru
Copy link
Collaborator

Hi @patroza.
I couldn't replicate the Typescript errors you are having when consuming the module with moduleResolution set to Node16, NodeNext or Bundler.

package.json already provides types:

"types": "./dist/types.d.ts",

Could you please provide further details?

@zoey-kaiser zoey-kaiser added bug A bug that needs to be resolved needs-reproduction Action needed: A valid reproduction of the issue needs to be added and removed needs reproduction needs-reproduction Action needed: A valid reproduction of the issue needs to be added labels Feb 23, 2024
Copy link

Hello 👋

Please provide a reproduction for this issue 🙏

How can I create a reproduction?

Please use one of the following links to reproduce your issue.

Please ensure that the reproduction is as minimal as possible. This will allow us to isolate the issue as best as possible.

Here are some more amazing posts about the importance of reproductions:

Copy link

github-actions bot commented Mar 9, 2024

This issue was closed because it was open for 14 days without a reproduction.

@github-actions github-actions bot added the closed-by-bot Closed by automation label Mar 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug that needs to be resolved closed-by-bot Closed by automation needs-reproduction Action needed: A valid reproduction of the issue needs to be added
Projects
None yet
Development

No branches or pull requests

3 participants