Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar button is weird #21

Open
stef opened this issue May 20, 2015 · 2 comments
Open

toolbar button is weird #21

stef opened this issue May 20, 2015 · 2 comments

Comments

@stef
Copy link

stef commented May 20, 2015

Howdy, since I don't use the url bar in firefox, I tried to move the toolbar button to the addonbar, but it seems the toolbar button is kinda weird, unlike most other plugins which provide a toolbar button, this is placed next to the menu button, and not in the area where the other toolbar buttons are. Also the toolbar button does not show up in browser.uiCustomization.state which would allow me to fiddle with it's position directly.
It would be really nice if your fine plugin would also work for vimperator and pentadactyl users. thanks for your great work!

@sibiantony
Copy link
Owner

Hi. Yes, the toolbar button creation is based on the old way of creating a button (and not using sdk etc). It requires some minor rewrites to get it done properly. As majority of the people stick with the default urlbar option, this wasn't a priority for the project.
Will look into that, please expect some delay.

Compatibility with other extensions - looks like a lot of work, unfortunately.

@stef
Copy link
Author

stef commented May 30, 2015

great! i think there's no issue with compatibility with other plugins, if you implement the button the way it is usually implemented, that is what other plugins also expect.
thanks for your great tool btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants