-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Bacon live reload on local runs #1967
Comments
While preparing the update to the instructions I realized that including as a library may not be an appropriate option. I'm not an expert on licences but bacon's licence is AGPL-3.0 and shuttle uses Apache-2.0 so I'm not sure library use would be permitted. |
Then we can try adding it as |
I like that plan, seems good to me. I like that it makes it clear that it's calling a 3rd party app. I also like that it's not required or opinionated. It leaves it open to support another tool if one comes up by not using |
I was thinking it over and realized there seems to be one issue. What about arguments to
I'm personally partial to (2). I think (3) is easier to implement but I feel it's less intuitive for a user of the shuttle binary. (2) allows a user to get everything working as they like in terms of options for |
Thought about that as well. I think |
I wouldn't mind trying to implement it at the same time. It may actually not be that hard and there aren't many so testing should be easy. If it proves to be complicated we can always abandon it after we try. |
Sure, go for it! :D |
Ok thanks. Might not have time to do it this week but I'll try to get started soon and open a Draft PR once I do. |
Describe the improvement
Continuation of #496
Add an easy way to run the complicated bacon "one liner" to the local run.
Implementation options:
Syntax options:
shuttle watch
shuttle run --watch
shuttle run --bacon
/shuttle run --use-bacon
I would pick calling the binary separately to not bloat cargo-shuttle with a huge dependency, and calling it
shuttle run --bacon
to highlight that it's an optional addon, and not built-in.Duplicate declaration
The text was updated successfully, but these errors were encountered: