From 88c6b77e85e1e4d5fa9f226a98e9b2ace5421688 Mon Sep 17 00:00:00 2001
From: Bryan Chen <xlchen1291@gmail.com>
Date: Tue, 31 Jan 2023 12:55:00 +1300
Subject: [PATCH] update

---
 .github/workflows/test.yml | 2 ++
 src/middleware/mod.rs      | 4 ++--
 src/server.rs              | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 411d2bf..575b45e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -20,6 +20,8 @@ jobs:
           submodules: recursive
     - name: Check format
       run: cargo fmt --all -- --check
+    - name: Check clippy
+      run: cargo clippy --all-targets --all-features -- -D warnings
     - name: Build
       run: cargo build --verbose
     - name: Run tests
diff --git a/src/middleware/mod.rs b/src/middleware/mod.rs
index 95c0b02..ada08ef 100644
--- a/src/middleware/mod.rs
+++ b/src/middleware/mod.rs
@@ -30,12 +30,12 @@ impl<Request: Send + 'static, Result: 'static> Middlewares<Request, Result> {
     }
 
     pub async fn call(&self, request: Request) -> Result {
-        let mut iter = self.middlewares.iter().rev();
+        let iter = self.middlewares.iter().rev();
         let fallback = self.fallback.clone();
         let mut next: Box<dyn FnOnce(Request) -> BoxFuture<'static, Result> + Send + Sync> =
             Box::new(move |request| (fallback)(request));
 
-        while let Some(middleware) = iter.next() {
+        for middleware in iter {
             let middleware = middleware.clone();
             let next2 = next;
             next = Box::new(move |request| {
diff --git a/src/server.rs b/src/server.rs
index b8aea62..2406297 100644
--- a/src/server.rs
+++ b/src/server.rs
@@ -101,7 +101,7 @@ pub async fn start_server(
         })
     })?;
 
-    let upstream = Arc::new(subscription::UpstreamMiddleware::new(client.clone()));
+    let upstream = Arc::new(subscription::UpstreamMiddleware::new(client));
 
     for subscription in &config.rpcs.subscriptions {
         let subscribe_name = string_to_static_str(subscription.subscribe.clone());