In Safari, NotFoundError is thrown when svg is cached

[boompikachu]

This error doesn't occur in Chrome

Error message:
NotFoundError: Failed to execute 'transaction' on 'IDBDatabase': One of the specified object stores was not found

No error if data-cache="disabled" is included in the svg tag

Seems to relate to jakearchibald/idb-keyval#134

[shubhamjain]

Sorry, haven't caught with issues for some time. Are you still facing this. I wasn't able to reproduce on my safari (both mac and iOS)

[honzabilek4]

I can confirm that the issue still exists.
I don't know exactly how this state occurs, but I was getting the same error when the keyval-store already existed.
It was empty and I wasn't able to run any operations on it. It's definitely related to jakearchibald/idb-keyval#134.
Anonymous window, or deleting the DB helped.

[shubhamjain]

Probably makes sense to solve it to cover #13 as well. If IndexedDB doesn't work, localStorage can be tried. LocalStorage has a limitation of 5MB but that should still be good enough for the cases where IndexedDB doesn't work.

The error though shouldn't affect loading of icons. Only that caching won't work for subsequent loads.

[honzabilek4]

Well, there's something wrong with the idb indeed and it sure affects the loading of the icons. The keyval-store is sometimes stuck, not responding to any commands and the icons won't load in Safari.

Sorry that I'm not providing any more details here, but I don't know how to reproduce it yet.

[honzabilek4]

Just in case you'd like to replace the storage system, I did it here with Sfirr
It also falls back to localStorage and if no localStorage is available it falls back to the memory cache which is exactly what we needed.
Works like a charm, and I can submit a PR if you wish.

[shubhamjain]

@honzabilek4 Thanks Siffr looks good! I would appreciate the PR. But I don't think we need WebSQL Storage (a dead API) and Cookies (bad for caching files). Although the library is tiny, I think it can be made even tinier, so we can consider including the library as a folder and remove the stuff that's not needed.

[honzabilek4]

I was thinking the same but needed to make it work quickly. It won't be difficult to it cut to the essentials and include it in the lib folder directly. Also, the CommonJS import is a little bit awkward. Please give me some time to get back to it, I'll submit a PR.

[shubhamjain]

@honzabilek4 Any progress on this? If not, I can initiate work on it.

[honzabilek4]

Hi,
I'm sorry, I was on vacation 🌴
I see that you've already implemented the localStorage fallback and updated the idb-keval library. It seems that they added this workaround for Safari, which should solve the issue.
Give me a day to test it, and I suppose we can close this.

[honzabilek4]

Works fine on my end right now.