Remove redundant code [Refactoring]

[shravan20]

Is your feature request related to a problem? Please describe.
Constant Values stored as JSON values are duplicated across the frontend and backend version.

Describe the solution you'd like
Remove the duplicated version inside the /frontend/src/util/animation/index.js file and use the existing backend-version src/animations/animation.js file

[raj5036]

Hi @shravan20 , I was studying the codebase, and wanted to start contributing.

This issue #135 seems like a good start. My question is should I delete the duplicate file altogether or just use the existing backend version while keeping the duplicate.

Thanks & Regards,
Raj Karmakar

[VishalSharma2000]

Hello @shravan20, I was walking through the code and as you have mentioned I found that the animation file is repeated in the frontend as well as backend. I think we can remove this redundant code in the below two ways

1. As you have told, we can keep the backend-version as it is and remove the frontend animation file, and further update the imports wherever the file has been used.
2. Else, we can have a global util directory, where we can place those files or utility functions that will have the same functionality in the frontend and backend.

I think the second approach is better, because in this way the file directory will be more understandable for everyone. If we follow the first approach then there can be some ambiguity in the frontend side when we are doing imports from the backend and also suppose in the future if the backend and frontend are split into different repositories then that may break the code.

Please let me know which method you think will be best and then I can start working on it if @raj5036 have not started the work.

[Peallyz]

Hi, is this issue still open ? May i work on it ?

[EmileGreyling]

Hi is this issue still open?

[shravan20]

Hi is this issue still open?

Yes, this is open

[codegeass56]

Hi. May I be assigned to work on this?

[shravan20]

Hi. May I be assigned to work on this?

Hey @codegeass56, feel free to pick this up and raise a PR. :)

[codegeass56]

Hi @shravan20,

I spent a few hours understanding the codebase. The issue boils down to the limitations of using create-react-app (CRA) which disallows importing a file from outside /src.

The most optimal solution (without affecting performance) is the existing one if you want to play by the rules of CRA.

Other solutions I have come across are:

1. Modifying server logic to send the file and fetch it in the front-end. (Would not be as fast as keeping the animation logic hardcoded in the front-end)
2. Removing ModuleScopePlugin entirely. (This would go against the rules of CRA and require significant testing)
3. Using sym links. (Only works locally)

I am interested to see how this issue is fixed and will be following it. For now, I am unassigning myself and will try to contribute elsewhere.

I am a novice when it comes to full-stack apps so pray tell if you have any suggestions :)

[besalraj30]

Hi

I’d like to work on this issue. Could you assign it to me?

[KDrop25]

hi can i work on this issue is it still open to work on ?

[Uriyo]

@besalraj30 are you still working on the issue?