Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings during cljs compilation with [org.clojure/clojurescript "0.0-2913"] #8

Open
bilus opened this issue Apr 23, 2015 · 2 comments

Comments

@bilus
Copy link

bilus commented Apr 23, 2015

WARNING: Bad method signature in protocol implementation, ITransientAssociative -assoc! does not declare arity 5 at line 27 file:/Users/martinb/.m2/repository/shoreleave/shoreleave-browser/0.3.0/shoreleave-browser-0.3.0.jar!/shoreleave/browser/cookies.cljs
WARNING: Bad method signature in protocol implementation, ITransientMap -dissoc! does not declare arity 4 at line 27 file:/Users/martinb/.m2/repository/shoreleave/shoreleave-browser/0.3.0/shoreleave-browser-0.3.0.jar!/shoreleave/browser/cookies.cljs
WARNING: Bad method signature in protocol implementation, ITransientAssociative -assoc! does not declare arity 5 at line 27 resources/public/js/out/shoreleave/browser/cookies.cljs
WARNING: Bad method signature in protocol implementation, ITransientMap -dissoc! does not declare arity 4 at line 27 resources/public/js/out/shoreleave/browser/cookies.cljs
@magomimmo
Copy link

Just saw your old issue. That WARNING depends what they say: a bugged implementation of those two CLJS protocols (i.e. ITransientAssociative and ITransientMac) for both -assoc! and -dissoc, for a total of 4 warnings. Old version of the CLJS compiler was not able to detect this warning (that immediately become errors if your're going to use them).

Here is a patched NON CANONICAL fork

[org.clojars.magomimmo/shoreleave-browser "0.3.1"]

HIH

@bilus
Copy link
Author

bilus commented Nov 27, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants