From bd88a17bd553e2043bd74fd2ea3f6264692d7996 Mon Sep 17 00:00:00 2001 From: Bryan Oltman Date: Mon, 9 Sep 2024 13:03:53 -0400 Subject: [PATCH] update comment --- src/content/docs/guides/hybrid-apps/android.mdx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/content/docs/guides/hybrid-apps/android.mdx b/src/content/docs/guides/hybrid-apps/android.mdx index 1ed7b8de..2e31bc77 100644 --- a/src/content/docs/guides/hybrid-apps/android.mdx +++ b/src/content/docs/guides/hybrid-apps/android.mdx @@ -97,8 +97,12 @@ In `app/build.gradle`, add the following: buildTypes { release { // ... -+ // Necessary to ensure the libapp.so produced by Shorebird matches the one that ends up -+ // in the APK. ++ // The Dart compiler builds libapp.so directly (does not use clang),and already strips ++ // symbols. However when llvm-strip is run on libapp.so, the symbols are re-sorted ++ // causing the hash of the library to change (which can confuse Shorebird tools). ++ // This line tells gradle to skip the unnecessary llvm-strip step for libapp.so ++ // thus ensuring that the libapp.so that Shorebird sees is byte-identical to the one ++ // which ends up in the APK/AAR/AAB. + packaging.jniLibs.keepDebugSymbols.add("**/libapp.so") // ... }