Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

API/Wallet version mismatch detection #132

Open
labs-dlugo opened this issue Jun 5, 2020 · 0 comments
Open

API/Wallet version mismatch detection #132

labs-dlugo opened this issue Jun 5, 2020 · 0 comments

Comments

@labs-dlugo
Copy link

  • Use package.json's major version digit. We are not using that digit for anything else since it's not a library.
  • Obviously respect Semantic Versioning from now on.
  • If API's major version digit does not match Wallet's, reject the connection.

I did explore some Wallet/API version matching through api-schema.ts in shock-common. Allows for more granular control but would require better GIT discipline (so shock-common v2 can get a non-breaking fix that also shock-common v3 gets).

Still not sure which path is better but API versions are a thing since always.

Lots of authorities do recommend API versioning through a header and not through URLs (e.g. foo.com/v1/posts) and I think it's a good fit (and easier to implement) for our use case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant