Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Damage not counting correctly with some things. (Hits and bots) #270

Open
Gawnz1 opened this issue Feb 15, 2025 · 4 comments
Open

Comments

@Gawnz1
Copy link

Gawnz1 commented Feb 15, 2025

Hits are not counted properly when player is in molotov/incendiary grenade (inferno damage for both). Since fire is DoT, it needs adjustments for the hits otherwise it will print wrong stats (hits) information.

Second thing:
If player do some damage and he dies and take a BOT (control a bot), it will count the player + the bot damage as one user and damage will be recorded multiple times.

@milkywayfarer
Copy link
Contributor

Also, any damage after the timer (when T's fail to plan, for example) does not count towards the round start stats in chat.

@Gawnz1
Copy link
Author

Gawnz1 commented Feb 18, 2025

@milkywayfarer, If I understood right, the damage is not being updated like the game hud after the round ends or some team wins the round/time expires and attacker does damage after this in the mp_round_restart_delay time basically.

This damage stats reporting is specially for/at the END ROUND. It is being fired/reported only for the end of the round. If we need to update the stats in real-time like the game hud, we will need to spam messages, since we can't edit our message.
Other workaround is to just print it on a new round (not round_end event), which I don't think this is the perfect idea.

Ideally, VALVe would be really nice to add an enemy hp along with teammate (I think only enemy HP is missing from the game hud at the moment) when round end or when starting the new round, so we can see everything needed and such information (plugin) would become useless from modders.

Someone who know more about how the DMG_BURN or specially the molotovs are working ingame can suggest a fix or at least some logic, so we can try to write code.

@milkywayfarer
Copy link
Contributor

@milkywayfarer, If I understood right, the damage is not being updated like the game hud after the round ends or some team wins the round/time expires and attacker does damage after this in the mp_round_restart_delay time basically.

This damage stats reporting is specially for/at the END ROUND. It is being fired/reported only for the end of the round. If we need to update the stats in real-time like the game hud, we will need to spam messages, since we can't edit our message. Other workaround is to just print it on a new round (not round_end event), which I don't think this is the perfect idea.

Ideally, VALVe would be really nice to add an enemy hp along with teammate (I think only enemy HP is missing from the game hud at the moment) when round end or when starting the new round, so we can see everything needed and such information (plugin) would become useless from modders.

Someone who know more about how the DMG_BURN or specially the molotovs are working ingame can suggest a fix or at least some logic, so we can try to write code.

Well I believe the last time I played with MatchZy, I saw the chat damage messages right at the start of the next round, so counting the round restart in does not sound like a lot of work.

@Gawnz1
Copy link
Author

Gawnz1 commented Feb 19, 2025

right at the start of the next round

https://github.com/shobhit-pathak/MatchZy/blob/dev/Utility.cs#L1052, which is in Round End 🤷
If your point or wanting is to move it on a NEW ROUND start - you can correct it yourself, just call it in another event and you are good to go.
I doubt that anyone will try to correct it like the real-time game hud updates.

Still, the 2 things from my first comment needs to be fixed, so we need some logic explaining from some skilled modder maybe. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants