engine: improved card drawing logic. #48
Merged
+51
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuv2707
reviewed
Jun 3, 2024
backend/uno-game-engine/engine.ts
Outdated
| @@ -48,10 +48,18 @@ export class GameEngine { | |||
| (this.currentPlayerIndex + this.direction) % this.players.length; | |||
| } | |||
| drawCardFromDeck(player: Player) { | |||
There was a problem hiding this comment.
The function should report if it successfully drew card for the player, else return an error.
See the EventResult type.
There was a problem hiding this comment.
Please review the changes.
kuv2707
reviewed
Jun 3, 2024
this commit handles the drawing logic from an empty cardDeck. - It reshuffles the thrown cards into the card deck when the card deck is empty and a player needs to draw a card. - It returns success message if the card is drawn successfully else returns message error. - Also added relevant unit test, in engine.test.ts, to verify this function (drawCardFromDeck) works correctly.
sethdivyansh
force-pushed
the
fix/issue-#8
branch
from
be3882e to
45c5330
Compare
|
Merged, thanks @sethdivyansh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8
Description
Handles the card drawing logic from an empty cardDeck.
drawCardFromDeck()works correctly.How to Test
I have created a sample test in engine.test.ts.
just run
npm testChecklist