frontend: Add Navbar #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuv2707
added
area: Frontend (structure)
AadityanshuSingh
approved these changes
Jun 4, 2024
|
Thanks @criticic for the Pull Request and @AadityanshuSingh for reviewing it. The navbar needs more refinement but seems good enough to be merged. Just fix the Linting issues and we are good to go |
This adds a UNO themed navbar to the frontend. The navbar is responsive and collapses into a hamburger menu on smaller screens. It can have multiple links, which can be defined on use. Fixes shivansh-bhatnagar18#19 Signed-off-by: Sagnik Mandal <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@shivansh-bhatnagar18 i have rebased the PR, kindly take a look now |
|
Looks like it would need to be worked on again in accordance with the new design. |
|
@criticic Thanks for the PR but I think we are working on the new design so I am closing this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a UNO themed navbar to the frontend. The navbar is responsive and collapses into a hamburger menu on smaller screens.
It can have multiple links, which can be defined on use.
Fixes #19
Description
Adds a Navigation Bar, (and removes some unnecessary css previously present, only using tailwind)
Motivation and Context
The design uses the UNO Red Color, and the logo is styled like the UNO Logo.
Checklist
Screenshots (if applicable)