Fixed the functionality of START_GAME Event #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Triggering Sync_State Event after Start_Game and draw_card event as these events make changes using backend functions These changes require to synced just after the event is triggered In preperation of shivansh-bhatnagar18#169
Abhishek-Punhani
force-pushed
the
FixIssue#169
branch
from
daf9f01 to
de335ed
Compare
kuv2707
reviewed
Jun 27, 2024
| useEffect(() => { | ||
| modal.show(<GamePropertiesModal />, 'large', [], false); | ||
| // eslint-disable-next-line | ||
| }, []); // todo add the required dependencies | ||
| }, [gameState.players.length, gameState.id]); // todo add the required dependencies |
There was a problem hiding this comment.
Including id here is necessary as previously explained. As long as the Game component is mounted, the game's id wont change.
This change will cause a UX inconvenience as previously mentioned, but we can ignore that for now.
There was a problem hiding this comment.
Without this , for joining players game id is not visible on the modal , so i included it , for now, i guess, we can keep it like this and fix this in upcoming prs.
frontend/src/pages/Game.tsx
Outdated
| @@ -78,10 +80,11 @@ function Game() { | |||
| const shuffledCards = [...cards].sort(() => Math.random() - 0.5); | |||
| return shuffledCards.slice(0, 7); | |||
| }, []); | |||
| console.log(gameState); | |||
Added handler for StartGame at frontend and made some minor corrections Fixes : shivansh-bhatnagar18#169
Abhishek-Punhani
force-pushed
the
FixIssue#169
branch
from
de335ed to
37b9e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added handler for StartGame at frontend and made some minor corrections. Also Triggered Sync_State Event after Start_Game and draw_card event as these events make changes using backend functions.
These changes require to synced just after the event is triggered
Fixes : #169
Checklist
Screenshots (if applicable)
[If your changes include any visual updates, provide screenshots here.]