From aec0ad3eca49a1b53ee63d1a0acd44c207f4f05b Mon Sep 17 00:00:00 2001 From: Kislay Date: Sun, 26 May 2024 15:39:01 +0530 Subject: [PATCH] workflows: Minor updates. Making checks pass. --- CONTRIBUTING.md | 1 + CONVENTIONS.md | 8 +++- backend/package.json | 2 +- frontend/src/App.css | 42 ++++++++++----------- frontend/src/App.tsx | 7 ++-- frontend/src/index.css | 84 +++++++++++++++++++++--------------------- frontend/src/main.tsx | 16 ++++---- 7 files changed, 83 insertions(+), 77 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2687aff..9ff810e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,6 +73,7 @@ Maintainers will approve the issue and add relevant labels to indicate that its - Editing commit history and rebasing are very valuable tools for keeping the commit history clean and easy to understand. Please familiarize yourself with these concepts before contributing. In any case, the seniors will be there to help you out. - Before starting work, run `git fetch upstream` and then `git rebase upstream/master`, to rebase your branch on top of the main branch. This will help you avoid merge conflicts, and sync your branch with the main branch. +- Addressing reviews on existing PRs is as important as creating new PRs. Please be responsive to the feedback and make the necessary updates. ## Code Review diff --git a/CONVENTIONS.md b/CONVENTIONS.md index 5f2f0b9..584c9b2 100644 --- a/CONVENTIONS.md +++ b/CONVENTIONS.md @@ -26,7 +26,13 @@ - Fixes: # + Fixes: # (omit this if there is no issue associated with the commit) + ``` + Some examples: + ``` + server: Add endpoint to fetch user data. + + This commit adds a new endpoint to the server that allows clients to fetch user data. ``` ## Other Important Points diff --git a/backend/package.json b/backend/package.json index 3314673..b8db567 100644 --- a/backend/package.json +++ b/backend/package.json @@ -18,7 +18,7 @@ "mongoose": "^8.4.0" }, "devDependencies": { - "eslint": "^9.3.0", + "eslint": "^8.57.0", "jest": "^29.7.0", "prettier": "^3.2.5", "supertest": "^7.0.0" diff --git a/frontend/src/App.css b/frontend/src/App.css index b9d355d..f44fb79 100644 --- a/frontend/src/App.css +++ b/frontend/src/App.css @@ -1,42 +1,42 @@ #root { - max-width: 1280px; - margin: 0 auto; - padding: 2rem; - text-align: center; + max-width: 1280px; + margin: 0 auto; + padding: 2rem; + text-align: center; } .logo { - height: 6em; - padding: 1.5em; - will-change: filter; - transition: filter 300ms; + height: 6em; + padding: 1.5em; + will-change: filter; + transition: filter 300ms; } .logo:hover { - filter: drop-shadow(0 0 2em #646cffaa); + filter: drop-shadow(0 0 2em #646cffaa); } .logo.react:hover { - filter: drop-shadow(0 0 2em #61dafbaa); + filter: drop-shadow(0 0 2em #61dafbaa); } @keyframes logo-spin { - from { - transform: rotate(0deg); - } - to { - transform: rotate(360deg); - } + from { + transform: rotate(0deg); + } + to { + transform: rotate(360deg); + } } @media (prefers-reduced-motion: no-preference) { - a:nth-of-type(2) .logo { - animation: logo-spin infinite 20s linear; - } + a:nth-of-type(2) .logo { + animation: logo-spin infinite 20s linear; + } } .card { - padding: 2em; + padding: 2em; } .read-the-docs { - color: #888; + color: #888; } diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx index 119cda5..bfad551 100644 --- a/frontend/src/App.tsx +++ b/frontend/src/App.tsx @@ -5,13 +5,12 @@ function App() { const [count, setCount] = useState(0); const a = 5; console.log(a); - function handleClick() { - setCount(count + 1); - } return ( <> -

UNO!!!

+

UNO!!!

Lets play a game of UNO! Click the button to draw a card.

+

Card: {count}

+ ); } diff --git a/frontend/src/index.css b/frontend/src/index.css index 6119ad9..279fff5 100644 --- a/frontend/src/index.css +++ b/frontend/src/index.css @@ -1,68 +1,68 @@ :root { - font-family: Inter, system-ui, Avenir, Helvetica, Arial, sans-serif; - line-height: 1.5; - font-weight: 400; + font-family: Inter, system-ui, Avenir, Helvetica, Arial, sans-serif; + line-height: 1.5; + font-weight: 400; - color-scheme: light dark; - color: rgba(255, 255, 255, 0.87); - background-color: #242424; + color-scheme: light dark; + color: rgba(255, 255, 255, 0.87); + background-color: #242424; - font-synthesis: none; - text-rendering: optimizeLegibility; - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; + font-synthesis: none; + text-rendering: optimizeLegibility; + -webkit-font-smoothing: antialiased; + -moz-osx-font-smoothing: grayscale; } a { - font-weight: 500; - color: #646cff; - text-decoration: inherit; + font-weight: 500; + color: #646cff; + text-decoration: inherit; } a:hover { - color: #535bf2; + color: #535bf2; } body { - margin: 0; - display: flex; - place-items: center; - min-width: 320px; - min-height: 100vh; + margin: 0; + display: flex; + place-items: center; + min-width: 320px; + min-height: 100vh; } h1 { - font-size: 3.2em; - line-height: 1.1; + font-size: 3.2em; + line-height: 1.1; } button { - border-radius: 8px; - border: 1px solid transparent; - padding: 0.6em 1.2em; - font-size: 1em; - font-weight: 500; - font-family: inherit; - background-color: #1a1a1a; - cursor: pointer; - transition: border-color 0.25s; + border-radius: 8px; + border: 1px solid transparent; + padding: 0.6em 1.2em; + font-size: 1em; + font-weight: 500; + font-family: inherit; + background-color: #1a1a1a; + cursor: pointer; + transition: border-color 0.25s; } button:hover { - border-color: #646cff; + border-color: #646cff; } button:focus, button:focus-visible { - outline: 4px auto -webkit-focus-ring-color; + outline: 4px auto -webkit-focus-ring-color; } @media (prefers-color-scheme: light) { - :root { - color: #213547; - background-color: #ffffff; - } - a:hover { - color: #747bff; - } - button { - background-color: #f9f9f9; - } + :root { + color: #213547; + background-color: #ffffff; + } + a:hover { + color: #747bff; + } + button { + background-color: #f9f9f9; + } } diff --git a/frontend/src/main.tsx b/frontend/src/main.tsx index 3d7150d..12afe2b 100644 --- a/frontend/src/main.tsx +++ b/frontend/src/main.tsx @@ -1,10 +1,10 @@ -import React from 'react' -import ReactDOM from 'react-dom/client' -import App from './App.tsx' -import './index.css' +import React from 'react'; +import ReactDOM from 'react-dom/client'; +import App from './App.tsx'; +import './index.css'; ReactDOM.createRoot(document.getElementById('root')!).render( - - - , -) + + + +);