From 2fd47890d39f9256a017d583dcb57d04433998e0 Mon Sep 17 00:00:00 2001 From: Kislay Date: Sun, 26 May 2024 15:39:01 +0530 Subject: [PATCH] docs: Minor updates. --- CONTRIBUTING.md | 1 + CONVENTIONS.md | 8 +++++++- frontend/src/App.tsx | 5 ++--- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2687aff..9ff810e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,6 +73,7 @@ Maintainers will approve the issue and add relevant labels to indicate that its - Editing commit history and rebasing are very valuable tools for keeping the commit history clean and easy to understand. Please familiarize yourself with these concepts before contributing. In any case, the seniors will be there to help you out. - Before starting work, run `git fetch upstream` and then `git rebase upstream/master`, to rebase your branch on top of the main branch. This will help you avoid merge conflicts, and sync your branch with the main branch. +- Addressing reviews on existing PRs is as important as creating new PRs. Please be responsive to the feedback and make the necessary updates. ## Code Review diff --git a/CONVENTIONS.md b/CONVENTIONS.md index 5f2f0b9..584c9b2 100644 --- a/CONVENTIONS.md +++ b/CONVENTIONS.md @@ -26,7 +26,13 @@ - Fixes: # + Fixes: # (omit this if there is no issue associated with the commit) + ``` + Some examples: + ``` + server: Add endpoint to fetch user data. + + This commit adds a new endpoint to the server that allows clients to fetch user data. ``` ## Other Important Points diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx index 119cda5..6200fbe 100644 --- a/frontend/src/App.tsx +++ b/frontend/src/App.tsx @@ -5,13 +5,12 @@ function App() { const [count, setCount] = useState(0); const a = 5; console.log(a); - function handleClick() { - setCount(count + 1); - } return ( <>

UNO!!!

Lets play a game of UNO! Click the button to draw a card.

+

Card: {count}

+ ); }