Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the specification of an output image optional #939

Open
gabemontero opened this issue Nov 8, 2021 · 0 comments
Open

Make the specification of an output image optional #939

gabemontero opened this issue Nov 8, 2021 · 0 comments
Labels
beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API ship-required

Comments

@gabemontero
Copy link
Member

gabemontero commented Nov 8, 2021

Although somewhat analogous to optional image push step there is also the concept of allowing the Build output image to be an optional field.

Reminder, it is already optional in the BuildRun, albeit that is simply because the user might not want to override what is specified in the Build.

Discussed in the Nov 8 2021 community meeting, this came up recently in a discussion in @sbose78 's image signature prototype, where I noted that the output image is optional with OpenShift Builds, and cited some of the reasons as to why which are relevant to Shipwright, most notably that the desired output of the build could something other than, or in addition to, a container image.

We also discussed some testing scenarios which warrant not wanting to require definition of an output image.

@adambkaplan this could also fall under the recent openshift build compatibility thread you are having with Siamak

@gabemontero gabemontero added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API ship-required labels Nov 8, 2021
@adambkaplan adambkaplan added this to the release-v1.0.0 milestone Nov 17, 2021
@adambkaplan adambkaplan added the beta BETA related issue label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API ship-required
Projects
None yet
Development

No branches or pull requests

2 participants