Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate spec.builder in the Build API #935

Open
adambkaplan opened this issue Nov 3, 2021 · 2 comments
Open

Deprecate spec.builder in the Build API #935

adambkaplan opened this issue Nov 3, 2021 · 2 comments
Labels
beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. ship-required

Comments

@adambkaplan
Copy link
Member

The Build API includes a spec.builder field, which lets users specify the "builder image" for a particular build strategy.
This field was initially added to support build strategies like source-to-image, which can feed in a base image to use for the build.

There are few build strategies that operate like this - Cloud Native Buildpacks might be the closest to using this approach, however our current strategies for buildpacks rely on separate strategies per build pack provider. Moreover, with the Parameters feature we can do away with this specialized API object and use more general-purpose parameters to inject the builder image. For example, the source-to-image build strategies can declare a BUILDER_IMAGE parameter that must be provided in a Build or BuildRun.

/kind feature

/kind cleanup

@openshift-ci openshift-ci bot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 3, 2021
@adambkaplan
Copy link
Member Author

Note that this issue should require a SHIP

@adambkaplan
Copy link
Member Author

@SaschaSchwarze0 noted that our current API also allows us to specify pull secrets for the builder image. For this to be fully deprecated, we need an alternate mechanism to provide pull secrets for the builder image. Using Build strategy volumes in combination with Build parameters is one potential solution.

@adambkaplan adambkaplan added the beta BETA related issue label Nov 17, 2021
@adambkaplan adambkaplan added this to the release-v1.0.0 milestone Nov 17, 2021
@adambkaplan adambkaplan added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta BETA related issue kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. ship-required
Projects
None yet
Development

No branches or pull requests

1 participant