Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Events for BuildRun objects #823

Open
adambkaplan opened this issue Jun 25, 2021 · 3 comments
Open

Emit Events for BuildRun objects #823

adambkaplan opened this issue Jun 25, 2021 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. ship-required

Comments

@adambkaplan
Copy link
Member

adambkaplan commented Jun 25, 2021

Idea:

The build controller should emit Kubernetes events for BuildRun objects. These should reflect the important state transitions for the BuildRun's lifecycle - namely if it started, if it succeeded, or if it failed.

The set of events we emit to the cluster can be the building blocks for events that can be emitted outside the cluster, through specifications like CloudEvents.

/kind feature

@adambkaplan adambkaplan added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2021
@adambkaplan
Copy link
Member Author

@SaschaSchwarze0 following up on your comment here: #824 (review)

I wasn't sure if adding events to the controller by itself warranted a SHP, since my initial intent was to not expose an API or configuration to tune the emitted events. In my experience controllers don't allow events to be configurable - they fire "Normal" events to provide object lifecycle information, and "Warning" events if something went wrong.

Kubernetes events are also considered ephemeral in nature - I believe by default events are reaped/deleted by the cluster after one hour.

@adambkaplan
Copy link
Member Author

(I do, however, think we need a SHP if we want to emit events outside the cluster via CloudEvents)

@adambkaplan
Copy link
Member Author

Based on the feedback in #824 - we should discuss in a SHIP what events we want to emit, and consider how Shiwpright events may overlap/conflict with Tekton events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. ship-required
Projects
None yet
Development

No branches or pull requests

1 participant