Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multi-arch ClusterBuildStrategy has Namespace Scoped Resources #1756

Open
1 task done
adambkaplan opened this issue Dec 17, 2024 · 1 comment
Open
1 task done
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@adambkaplan
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

v1.31.z

Shipwright Version

v0.14.0

Current Behavior

The multi-arch cluster build strategy includes namespace-scoped roles and rolebindings. This made it challenging to deploy with the Shipwright operator

Expected Behavior

Cluster build strategy examples should only include cluster-scoped resources in manifests.

Steps To Reproduce

Deploy the cluster samples for v0.14.0 release using kubectl apply -f:

kubectl apply --filename https://github.com/shipwright-io/build/releases/download/v0.14.0/sample-strategies.yaml --server-side

Sample strategies will include namespace-scoped roles and rolebindings.

Anything else?

No response

@adambkaplan adambkaplan added the kind/bug Categorizes issue or PR as related to a bug. label Dec 17, 2024
@adambkaplan adambkaplan added this to the release-v0.15.0 milestone Feb 6, 2025
@adambkaplan
Copy link
Member Author

Adding this to the v0.15.0 backlog - keeping this build strategy cluster-scoped broke the operator when we tried to import the latest set of sample build strategies.

Moving this to be a namespace-scoped build strategy should fix the issue on the operator side.

@adambkaplan adambkaplan added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Todo
Development

No branches or pull requests

2 participants