Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Missing samples? #1066

Open
rolfedh opened this issue May 20, 2022 · 0 comments
Open

Docs: Missing samples? #1066

rolfedh opened this issue May 20, 2022 · 0 comments

Comments

@rolfedh
Copy link
Contributor

rolfedh commented May 20, 2022

In https://shipwright.io/docs/api/build/#configuring-a-build,
the link in the following line is broken:
"spec.strategy - Refers to the BuildStrategy to be used, see the examples".

Does this simply an outdated path that should be pointing to https://github.com/shipwright-io/build/blob/main/test/buildstrategy_samples.go?
Or is the intention to have a samples folder that contains a collection of sample files that are derived from the test folder's contents?

I'm creating the downstream docs and would like to provide a similar experience as the upstream docs: See https://github.com/openshift/openshift-docs/pull/45565/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant