Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write integration tests with now known fail cases for master #31

Closed
mathieuboudreau opened this issue Jan 16, 2025 · 2 comments
Closed
Assignees
Labels

Comments

@mathieuboudreau
Copy link
Member

The two example cases (sphere and cylinder) that were prepared in a script (https://github.com/shimming-toolbox/susceptibility-to-fieldmap-fft/blob/main/functions/analytical_cases.py) should be moved/refactored/reused in tests.

These currently only worked for some specific settings if I recall (eg even dimensions or even padding) since there was some hardcoding,

https://github.com/shimming-toolbox/susceptibility-to-fieldmap-fft/blob/main/functions/analytical_cases.py

The integration tests should test many more cases (eg all odd, mix between even and odd) and different sizes. The phantom position could also maybe be moved?

@mathieuboudreau
Copy link
Member Author

@mathieuboudreau
Copy link
Member Author

Done in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 1 day
Development

No branches or pull requests

1 participant