Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status icon (aka. badge) for vaults shared but not yet granted access #9

Open
chenkins opened this issue Jul 7, 2023 · 5 comments
Open
Labels
katta-client-native Mountain Duck

Comments

@chenkins
Copy link
Collaborator

chenkins commented Jul 7, 2023

Story

  • Persona: cipherduck user
  • Need: feedback on which vaults can/cannot be opened
  • Purpose: not being confused

Acceptance Criteria

Open Questions

  • same in hub?
  • which icon or filter out?

Context/Notes

@chenkins chenkins added v1 katta-clientlib katta-clientlib labels Jul 7, 2023
@chenkins chenkins changed the title Badge for vaults shared but granted access Visual badge for vaults shared but granted access Jul 7, 2023
@overheadhunter
Copy link
Collaborator

Can you elaborate this? Might be something that needs to go upstream

@chenkins chenkins changed the title Visual badge for vaults shared but granted access Status icon for vaults shared but granted access Jul 10, 2023
@chenkins chenkins changed the title Status icon for vaults shared but granted access Status icon (aka. badge) for vaults shared but granted access Jul 10, 2023
@chenkins
Copy link
Collaborator Author

@overheadhunter status icon aka. badge see https://docs.mountainduck.io/mountainduck/sync/#status-of-files.

Alternative: we do not show these vaults at all, we filter out those requiring access grant in the client.

TODO need to check how these vaults are displayed in the hub.

cryptomator/cryptomator@develop...feature/new-hub-keyloading -> "URI constructed from params known to be valid". If I understand correctly, users need to add vaults themselves to cryptomator client (there is no open all vaults under this folder to my knowledge, is there?), so here less of a problem.

@overheadhunter
Copy link
Collaborator

Oh I see, so this is a client-side feature. There is no such thing in Cryptomator: You can add any vault to its list and will only know whether you can unlock it (or why you can't) when attempting to do so.

I have mistaken this for a Hub (i.e. web app) feature, but I guess you use this repo to track issues for both sides?

@chenkins
Copy link
Collaborator Author

@overheadhunter yes, the idea is to track everything cipherduck-specific here (hub upstream issues go to cryptomator/hub directly) and to use the issue labels client and hub. Let me know if that does not work well for you.

@chenkins chenkins removed the v1 label Aug 24, 2023
@chenkins chenkins added this to the v1 milestone Aug 24, 2023
@chenkins chenkins added the wontfix This will not be worked on label Aug 31, 2023
@chenkins chenkins reopened this Sep 1, 2023
@chenkins chenkins removed the wontfix This will not be worked on label Sep 1, 2023
@chenkins
Copy link
Collaborator Author

chenkins commented Oct 24, 2023

Current implementation filters them out, see 403 -> continue in HubSession.sync() -> we could display the bookmarks in the menu greyed out, but never connect.

@chenkins chenkins changed the title Status icon (aka. badge) for vaults shared but granted access Status icon (aka. badge) for vaults shared but not yet granted access Nov 10, 2023
@chenkins chenkins modified the milestones: v1, v2 Nov 10, 2023
@chenkins chenkins removed this from the v2 milestone Mar 13, 2024
@chenkins chenkins added katta-client-native Mountain Duck and removed katta-clientlib katta-clientlib labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
katta-client-native Mountain Duck
Projects
None yet
Development

No branches or pull requests

2 participants