-
Notifications
You must be signed in to change notification settings - Fork 11
/
Copy path.eslintrc.js
227 lines (185 loc) · 6.64 KB
/
.eslintrc.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
module.exports = {
extends: [
'airbnb',
'airbnb-typescript',
'plugin:react/jsx-runtime',
'plugin:jsx-a11y/recommended',
'plugin:jest/recommended',
'plugin:jest/style',
'plugin:@typescript-eslint/recommended',
'plugin:import/typescript',
'prettier',
],
parserOptions: { tsconfigRootDir: __dirname, project: './tsconfig.eslint.json' },
env: { es2021: true, browser: true, node: true, 'jest/globals': true },
plugins: ['react-hooks', 'testing-library', 'jest'],
rules: {
// enforce curly brace usage
curly: ['error', 'all'],
// allow class methods which do not use this
'class-methods-use-this': 'off',
// Allow use of ForOfStatement - no-restricted-syntax does not allow us to turn off a rule. This block overrides the airbnb rule entirely
// https://github.com/airbnb/javascript/blob/7152396219e290426a03e47837e53af6bcd36bbe/packages/eslint-config-airbnb-base/rules/style.js#L257-L263
'no-restricted-syntax': [
'error',
{
selector: 'ForInStatement',
message:
'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
},
{
selector: 'LabeledStatement',
message:
'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
},
{
selector: 'WithStatement',
message:
'`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
},
],
// enforce consistent sort order
'sort-imports': ['error', { ignoreCase: true, ignoreDeclarationSort: true }],
// enforce convention in import order
'import/order': [
'error',
{
'newlines-between': 'never',
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
alphabetize: { order: 'asc', caseInsensitive: true },
},
],
// ensure consistent array typings
'@typescript-eslint/array-type': 'error',
// ban ts-comment except with description
'@typescript-eslint/ban-ts-comment': [
'error',
{
'ts-expect-error': 'allow-with-description',
'ts-ignore': 'allow-with-description',
'ts-nocheck': true,
'ts-check': false,
},
],
// prefer type imports and exports
'@typescript-eslint/consistent-type-exports': [
'error',
{ fixMixedExportsWithInlineTypeSpecifier: true },
],
'@typescript-eslint/consistent-type-imports': ['error', { prefer: 'type-imports' }],
// enforce consistent order of class members
'@typescript-eslint/member-ordering': 'error',
// disallow parameter properties in favor of explicit class declarations
'@typescript-eslint/no-parameter-properties': 'error',
// disable function-component-definition rule enabled by airbnb
'react/function-component-definition': 'off',
// tab indentation
'react/jsx-indent': ['error', 'tab'],
'react/jsx-indent-props': ['error', 'tab'],
// permit spreading of props
'react/jsx-props-no-spreading': 'off',
// React triggers no-unused-vars rules
'react/jsx-uses-react': 'off',
// typescript is better at prop-types than `prop-types`
'react/prop-types': 'off',
// disable react-in-jsx-scope (must use @babel/preset-react option { runtime: 'automatic' })
// see: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html and https://babeljs.io/docs/en/babel-preset-react/#runtime
'react/react-in-jsx-scope': 'off',
// check effect dependencies
'react-hooks/exhaustive-deps': 'warn',
// check rules of react hooks
'react-hooks/rules-of-hooks': 'error',
},
overrides: [
{
files: ['**/*.ts', '**/*.tsx'],
extends: ['plugin:@typescript-eslint/recommended-requiring-type-checking'],
rules: {
// disable rules turned on by @typescript-eslint/recommended-requiring-type-checking which are too noisy
// https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/recommended-requiring-type-checking.ts
'@typescript-eslint/no-unsafe-argument': 'off',
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
'@typescript-eslint/restrict-template-expressions': 'off',
'@typescript-eslint/unbound-method': 'off',
// force explicit member accessibility modifiers
'@typescript-eslint/explicit-member-accessibility': 'error',
},
},
{
files: ['*.tsx'],
rules: {
// no proptypes in typescript components
'react/require-default-props': 'off',
},
},
{
files: ['**/index.ts', '**/index.tsx'],
rules: {
// prefer named exports for certain file types
'import/prefer-default-export': 'off',
'import/no-default-export': 'error',
},
},
{
files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[jt]s?(x)'],
extends: ['plugin:testing-library/react'],
rules: {
// allow tests to create multiple classes
'max-classes-per-file': 'off',
// allow side effect constructors
'no-new': 'off',
// allow import with CommonJS export
'import/no-import-module-exports': 'off',
// disallow use of "it" for test blocks
'jest/consistent-test-it': ['error', { fn: 'test', withinDescribe: 'test' }],
// ensure all tests contain an assertion
'jest/expect-expect': 'error',
// no commented out tests
'jest/no-commented-out-tests': 'error',
// no duplicate test hooks
'jest/no-duplicate-hooks': 'error',
// valid titles
'jest/valid-title': 'error',
// no if conditionals in tests
'jest/no-if': 'error',
// expect statements in test blocks
'jest/no-standalone-expect': 'error',
// disallow returning from test
'jest/no-test-return-statement': 'error',
// disallow truthy and falsy in tests
'jest/no-restricted-matchers': ['error', { toBeFalsy: null, toBeTruthy: null }],
// prefer called with
'jest/prefer-called-with': 'error',
},
},
{
files: ['**/__tests__/**/*.ts?(x)', '**/?(*.)+(spec|test).ts?(x)'],
rules: {
// allow explicit any in tests
'@typescript-eslint/no-explicit-any': 'off',
// allow non-null-assertions
'@typescript-eslint/no-non-null-assertion': 'off',
// allow empty arrow functions
'@typescript-eslint/no-empty-function': ['error', { allow: ['arrowFunctions'] }],
},
},
{
files: [
'**/__tests__/**/*.[jt]s?(x)',
'**/?(*.)+(spec|test).[jt]s?(x)',
'**/example/*.ts?(x)',
'**/scripts/*.ts?(x)',
],
rules: {
// allow dev dependencies
'import/no-extraneous-dependencies': [
'error',
{ devDependencies: true, optionalDependencies: false, peerDependencies: false },
],
},
},
],
};