Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ਯ should be open top in final Pauri of Jaap Sahib #1897

Closed
TSingh1699 opened this issue Dec 4, 2023 · 5 comments · Fixed by #1898
Closed

ਯ should be open top in final Pauri of Jaap Sahib #1897

TSingh1699 opened this issue Dec 4, 2023 · 5 comments · Fixed by #1898
Labels
○ Type Bug Regressions/production issues that do not function as intended.

Comments

@TSingh1699
Copy link
Contributor

Describe the bug

Open top ਯ is used in Budha Dal Mehron and in Hazoor Sahib
IMG_20231204_001012~2
IMG_20231204_001726~3

Environment

No response
@TSingh1699 TSingh1699 added the ○ Type Bug Regressions/production issues that do not function as intended. label Dec 4, 2023
@bhajneet
Copy link
Member

bhajneet commented Dec 4, 2023

Confirmed, thank you. Would you care to take some time to open a PR for this issue?

@TSingh1699 TSingh1699 reopened this Dec 4, 2023
@TSingh1699
Copy link
Contributor Author

Hanji I'll try

@TSingh1699 TSingh1699 mentioned this issue Dec 4, 2023
Merged
@sarabveer
Copy link
Collaborator

sarabveer commented Dec 4, 2023 •
edited
Loading

The change was made to SGPC, shoudn't a new gurmukhi source be created for that line using Budha Dal Mehron?

@TSingh1699
Copy link
Contributor Author

I also just noticed ਸਰਬਦਾ doesn't have a gap in Mehron. Should a new issue be opened?

@bhajneet
Copy link
Member

bhajneet commented Dec 5, 2023

The changes to DB as far as I know do not affect anything anymore. The new API or DB has support for multiple sources. This is just for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(data): Change Yayya to open top in Jaap Sahib TSingh1699/database
3 participants
@sarabveer @bhajneet @TSingh1699