-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoreload failed. Got Error: Callback was already called #84
Comments
What is "Sails auto-migration" ? Is it a package ? |
Auto-migration here https://sailsjs.com/documentation/concepts/models-and-orm/model-settings |
This should work without trouble. Please, provide a reproduction repo with minimal setup. |
same issue here. I have a fresh new project, this is my package.json: {
"name": "xxx",
"private": true,
"version": "0.0.0",
"description": "a Sails application",
"keywords": [],
"dependencies": {
"async": "2.0.1",
"connect-redis": "3.2.0",
"grunt": "1.0.1",
"lodash": "3.10.1",
"sails": "^1.0.0-40",
"sails-ember-rest": "^1.0.12",
"sails-hook-grunt": "^2.0.0",
"sails-hook-orm": "^2.0.0-16",
"sails-hook-sockets": "^1.4.0",
"sails-postgresql": "^1.0.0-12",
"socket.io-redis": "4.0.0"
},
"devDependencies": {
"eslint": "3.19.0",
"sails-hook-autoreload": "^1.1.0"
},
"scripts": {
"start": "NODE_ENV=production node app.js",
"test": "npm run lint && npm run custom-tests && echo 'Done.'",
"lint": "node ./node_modules/eslint/bin/eslint . --max-warnings=0 && echo '✔ Your code looks good.'",
"custom-tests": "echo \"(No other custom tests yet.)\" && echo",
"debug": "node debug app.js"
},
"main": "app.js"
} |
@L1br3 Steps to reproduce:
Issue dissappears if you drop |
Thanks @gleam-ru I'm going to have a look. As I don't use sails 1.x for now I didn't dive into this earlier. If you succeed making a FIX, don't hesitate to PR or share it here. |
Hello, I have updated my dependencies and now I have the same issue. After some search, I found that the "async" module have breaking changes in its v2.0.0, and it seems to match this issue : "Calling a callback more than once is considered an error, and an error will be thrown. This had an explicit breaking change in waterfall. If you were relying on this behavior, you should more accurately represent your control flow as an event emitter or stream." |
Same thing here, with a fresh Sails 1.0 generated project |
No update on this blocking issue since months, it seems this project is dead like Sails.js, sad... |
Sorry I didn't take the time to solve it.
Le 1 mars 2018 15:04, "Zeex" <[email protected]> a écrit :
… No update on this blocking issue since months, it seems this project is
dead like Sails.js, sad...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUhqS_sJv-KylDTHflfGzjLaS9uvLAHks5tZ__ZgaJpZM4QdCEg>
.
|
+1 |
2 similar comments
+1 |
+1 |
waiting... |
I'm so busy dudes. I understand its blocking for you but money comes before
open source and Im sure all of you understand that.
As we have the reproduction repo, maybe one of you who getting the error
can make some research and try to fix the bug.
As soon as someone has a fix I can merge PR and ask repo owner to publish
on npm.
Im really sorry and I really would like to magically solve this one as it
seems to completely breack this package.
Le lun. 23 avr. 2018 à 00:00, l132a <[email protected]> a écrit :
… waiting...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUhqQ6FdKL0BAPuMBslXTIrJk0ogr20ks5trLcigaJpZM4QdCEg>
.
|
+1 |
2 similar comments
+1 |
+1 |
In './config/models.js' file I add ''
|
@Wisperus thanks, nice workaround while waiting for a fix |
Any update on a fix? Would be great to not disable archiveModel 🤔 |
temporary do,
in model config |
The |
Did someone found a fix for this one ? The problem looks to be located in waterline so we need another way to reload ORM otherwise the callback is called more than once. |
also worked for me using the actual sails 1.0 version. Anyway, for those stumbling upon the same question o similar scenario of mine: I wanted to use the You can use nodemon directly with the sails binary, using the normal argumments that you would pass to it. Personally, I drop this line under the package.json scripts section.
Hope somebody find this useful ☘️ |
I updated the readme to document that bug. |
@L1br3 |
Does anyone know what the |
Hi @L1br3 , The The identity of the model to use when calling .archive(). By default, this is the Archive model, an implicit model automatically defined by Sails/Waterline. Set to false to disable built-in support for soft-deletes. |
Every time Autoreload happens, Sails auto-migration will run but I got following error:
The text was updated successfully, but these errors were encountered: