feat: Enhance contract state management and CLI listing

[JohnPhamous]

• Add new utils.ts for contract state logic
• Refactor contract types to support more precise status handling
• Implement getContractState and getContractStateColor utilities
• Add --all flag to contract list command for comprehensive contract display
• Improve contract filtering and state determination

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
src/lib/buy/index.tsx	100% smaller
src/lib/contracts/ContractDisplay.tsx	18% smaller
src/lib/contracts/index.tsx	16% smaller
src/lib/contracts/types.ts	5% smaller
package.json	0% smaller
src/lib/contracts/utils.ts	0% smaller

[greptile-apps]

PR Summary

This PR enhances contract management by introducing state-based filtering and improving code organization through dedicated utility functions.

• Added new src/lib/contracts/utils.ts with getContractState and getContractStateColor functions for centralized state management
• Introduced --all flag in src/lib/contracts/index.tsx to optionally display expired contracts in listing
• Refactored src/lib/contracts/types.ts with clearer contract type definitions, though status field handling needs improvement
• Modified src/lib/contracts/ContractDisplay.tsx to use new utility functions for consistent state determination
• Improved error message formatting in src/lib/buy/index.tsx for cancelled orders

_{6 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: Type assertion could fail if contract.status is not 'active'. Consider adding a runtime check for contract.status before casting.

Suggested change

	const activeContract = contract as ActiveContract;
	const state = getContractState(activeContract);
	if (contract.status !== 'active') {
	continue;
	}
	const activeContract = contract as ActiveContract;
	const state = getContractState(activeContract);

[greptile-apps]

logic: ActiveContract's status field should exclude "pending" since that's handled by PendingContract. Change to: status: Exclude<ContractStatus, "pending">

Suggested change

	export interface ActiveContract extends BaseContract {
	status: ContractStatus;
	export interface ActiveContract extends BaseContract {
	status: Exclude<ContractStatus, "pending">;

[greptile-apps]

logic: Missing validation for empty intervals array. Will throw if contract.shape.intervals is empty.

Suggested change

	const startsAt = new Date(contract.shape.intervals[0]);
	const endsAt = new Date(
	contract.shape.intervals[contract.shape.intervals.length - 1],
	);
	if (!contract.shape.intervals.length) {
	throw new Error('Contract must have at least one interval');
	}
	const startsAt = new Date(contract.shape.intervals[0]);
	const endsAt = new Date(
	contract.shape.intervals[contract.shape.intervals.length - 1],
	);

[greptile-apps]

style: Missing exhaustive type checking. TypeScript won't catch if a new ContractState is added without updating this function.

Suggested change

	export function getContractStateColor(
	state: ContractState,
	): "green" | "gray" | "cyan" {
	switch (state) {
	case "Upcoming":
	return "green";
	case "Expired":
	return "gray";
	case "Active":
	return "cyan";
	}
	}
	export function getContractStateColor(
	state: ContractState,
	): "green" | "gray" | "cyan" {
	switch (state) {
	case "Upcoming":
	return "green";
	case "Expired":
	return "gray";
	case "Active":
	return "cyan";
	default:
	const exhaustiveCheck: never = state;
	throw new Error(`Unhandled contract state: ${exhaustiveCheck}`);
	}
	}