-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Clusters/Contracts List #76
Better Clusters/Contracts List #76
Conversation
Changed Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances cluster and contract display functionality with improved UI components and comprehensive mock data for testing.
- Added
/src/lib/clusters/mock.ts
and/src/lib/contracts/mock.ts
with test data covering various states (upcoming, active, expired) and configurations - Enhanced
/src/lib/clusters/clusters.tsx
with new color-coded status badges and better interval data visualization - Introduced
/src/lib/clusters/types.ts
withUserFacingCluster
interface for consistent typing - Refactored
/src/lib/contracts/ContractDisplay.tsx
to uselittle-date
and improved status indicators - Added VM-related endpoints and contract fields in
/src/schema.ts
8 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -22,8 +23,10 @@ | |||
"ink": "^5.0.1", | |||
"ink-confirm-input": "^2.0.0", | |||
"ink-spinner": "^5.0.0", | |||
"ink-testing-library": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: ink-testing-library should be in devDependencies since it's only used for testing
"ink-testing-library": "^4.0.0", | |
"ink-testing-library": "^4.0.0", |
{intervalData.map((data, index) => { | ||
return ( | ||
<Box | ||
key={`${index}-${data.quantity}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: key should use interval start time instead of quantity since quantity could be duplicated within the same contract
No description provided.