Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coercedStart #71

Merged
merged 3 commits into from
Feb 16, 2025
Merged

fix coercedStart #71

merged 3 commits into from
Feb 16, 2025

Conversation

Sladuca
Copy link
Contributor

@Sladuca Sladuca commented Feb 16, 2025

No description provided.

Copy link

semanticdiff-com bot commented Feb 16, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  100% smaller
  src/lib/buy/index.tsx  72% smaller

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes date handling in the buy order functionality by ensuring consistent date parsing and calculation of end dates.

  • Fixed duration calculation by using coercedStart instead of raw startAt value in src/lib/buy/index.tsx
  • Added debug logging for order props and buy request parameters
  • Refactored API request body construction for improved code readability
  • Prevents potential incorrect duration calculations by properly parsing start dates

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Sladuca Sladuca merged commit c734ef3 into main Feb 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant