Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add feature flags #68

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Conversation

JohnPhamous
Copy link
Contributor

No description provided.

Copy link

semanticdiff-com bot commented Feb 14, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  100% smaller
  src/helpers/feature-flags.ts  0% smaller
  src/index.ts  0% smaller
  src/lib/posthog.ts  0% smaller
  src/lib/vm.ts  0% smaller
  src/types/deno.d.ts  0% smaller

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added feature flag functionality to the CLI using PostHog, enabling granular control over feature availability based on user account IDs.

  • Added FeatureFlags type in src/lib/posthog.ts with initial support for 'vms' feature
  • Implemented isFeatureEnabled function in src/lib/posthog.ts to check feature availability per user
  • Missing error handling for PostHog API calls in isFeatureEnabled function
  • Relies on existing account ID from config, defaulting to false if ID not found

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@JohnPhamous JohnPhamous merged commit 85aab26 into main Feb 14, 2025
1 check passed
@sigmachirality sigmachirality deleted the johnphamous/eng-1317-add-feature-flagging branch February 15, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant