-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offering to maintain nps #234
Comments
Yeah, I took over because my previous job was using it and it wasn't being maintained. Now, I'm no longer in that role and I haven't had the time to give it any love. Happy to find somebody who is willing to give it the love it needs! |
Awesome! How do we go about transferring this? Would it make sense to transfer the npm package ownership so we can publish from our repo moving forward? |
@mf-bruce have you taken over the project? |
Yep, you can find our fork Would be nice to transfer the original package name on npm, or at least deprecate it. FYI it's possible the npm deploy key for the original package was leaked via travis:( https://arstechnica.com/information-technology/2021/09/travis-ci-flaw-exposed-secrets-for-thousands-of-open-source-projects/ |
@sezna the current status quo will work fine for folks who proactively want to use a newer version of
|
I stumbled upon this package today and found it very interesting. But looking at the last commit almost 2 years ago, was hesitant to pick it up. Until I saw this issue. Great job @mf-bruce to keep it going. I would personally like to see mf-bruce's fork merged over here so that star ratings can be maintained. There is a lot of equity build into the stars and the downloads - would be sad to loose it all. Also, there is the complication of moving the issues and all. @Senza, in the best interest of the community, please consider merging mf-bruce's fork here and giving him permissions to publish on npm. You both can co-own the package (or may be create an org for it). P.S. I also see @kentcdodds on the contributor's list, so this has to be good :-) |
Hey Naresh, yeah, I thought I had time for this many years ago but I haven't. We used it at my last company, and it was going unmaintained, so I took over. But, here I am, in the same situation. It looks like Bruce has left Markforged, though, so I'm not sure who a good contact would be. And it looks like their fork isn't a "fork" in that I can't merge from it. It also hasn't seen much activity. If anybody would be interested in maintaining this package, I'd be happy to transfer it. |
I think I might be interested, but I'm engaged with other projects for the next few months... I will let you know... |
First off, thanks @sezna for building nps in the first place! We have been using it at Markforged for some time now, and have found it to be elegant in its simplicity, whilst providing just enough functionality to be incredibly powerful!
It seems that nps has lacked maintenance for some years now, there are outstanding security issues, and feature requests such as positional args (something we have implemented in our fork).
We would like to offer to maintain the
nps
package, so opening this issue to start that conversation!The text was updated successfully, but these errors were encountered: