Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

Redundant application of mask #54

Open
torms3 opened this issue Feb 17, 2016 · 2 comments
Open

Redundant application of mask #54

torms3 opened this issue Feb 17, 2016 · 2 comments

Comments

@torms3
Copy link
Contributor

torms3 commented Feb 17, 2016

Mask is being applied to both output activation and target label in cost functions. Applying mask to the resulting gradient (https://github.com/seung-lab/znn-release/blob/master/python/train.py#L102) is redundant.

@xiuliren
Copy link
Member

@torms3 could you point out the code masking the activation or target label? I think that we only masked the gradient.

@nicholasturner1
Copy link
Contributor

I put that into cost_fn.py (e.g. https://github.com/seung-lab/znn-release/blob/master/python/cost_fn.py#L30) some time ago to start decreasing the occurrences of NAN values. I have some other updates for the specific implementation there (changing mask_dict_vol), but I think this is the better place for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants