Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Log IP of the requests originated from #261

Open
aaira-a opened this issue Oct 28, 2023 · 3 comments
Open

Request: Log IP of the requests originated from #261

aaira-a opened this issue Oct 28, 2023 · 3 comments
Assignees

Comments

@aaira-a
Copy link

aaira-a commented Oct 28, 2023

Is it possible to add IPs to the debug log?

@phybros
Copy link
Collaborator

phybros commented Oct 31, 2023

What do you mean? Which log messages?

@aaira-a
Copy link
Author

aaira-a commented Oct 31, 2023

Background: We are using ServerTap on a multiplayer server. More than one clients are calling the v1/server/exec endpoint, with the shared secret.

In example here, if we turn on debug: true in ServerTap config, there is an INFO line logged, showing that the v1/server/exec endpoint was called.

Actual log in my console: 31.10 03:32:18 [Server] INFO /v1/server/exec.
My question is whether it is possible to add the caller's IP to this line for tracing the source.

Another extension to this is to actually log the request body of the request itself for security/audit purposes, but I feel that logging IP should be enough for now.

@phybros phybros self-assigned this Nov 27, 2023
@MeesJ
Copy link

MeesJ commented May 8, 2024

If this is added, the X-Forwarded-For header should be supported for this to avoid the logs only returning the IP address of the reverse proxy sitting in front of ServerTap (if any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants