Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now using Serilog version 2.x to prevent Serilog.FullNetFx issue #20

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Conversation

jansoren
Copy link
Contributor

No description provided.

@jansoren
Copy link
Contributor Author

@nblumhardt - could you please consider the pull request? I have now managed to get the right version on the build :-)

@nblumhardt
Copy link
Contributor

Hi @jansoren - looking good. (To keep the history of discussion on a PR, you can force-push to your PR branch; #18 and #19 have a bit of context for this one.)

Merging now, since I know this is blocking you, but when you have a chance could you please submit a fresh PR to reinstate the PowerShell-based versioning?

https://github.com/serilog/serilog-sinks-mssqlserver/pull/20/files#diff-e85dc2dd76aaf612160c0b1ffbcccc92L9

Serilog was originally on TeamCity; when we moved to AppVeyor we switched from using the build server's assemby info patching to our own, so that a) we can repro builds locally and b) we're not too tied into the specific CI platform lest we move again someday.

Thanks for persisting with this one 👍 - appreciate all the effort and input!

@nblumhardt nblumhardt merged commit 44fddd8 into serilog-mssql:dev Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants