Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the edit command in VS Code (to never open the revision box in VS code) #6

Open
katarinaslama opened this issue Jun 17, 2022 · 1 comment
Labels
approved Approved for implementation feature-request New feature or request

Comments

@katarinaslama
Copy link

Context

I never have a reason to use the revision box in VS Code. However, serenade often mis-hears "indent" as "edit" and opens the annoying revision box. Tommy tells me that there is no way to suppress this behavior (since changing settings.json does not solve this version of suppressing the revision box.) and suggested that that I open an issue here.

I made a quick fix by adding this to custom.js:
serenade.app("code").command("edit", async (api) => {
await api.pressKey();
});

But this does not fix the case where serenade mis hears "line 88" as "line, edit".

Goals

Make an option to disable the 'edit' command in vs code.

Proposed Solution

Make an option to disable the 'edit' command in vs code.

Alternatives

Maybe there's a way to solve the "line 88" issue? This didn't work though:

serenade.app("code").command("line, edit", async (api) => {
await api.pressKey("g", ["ctrl"]);
await api.typeText("88");
});

Thanks!

@katarinaslama katarinaslama added feature-request New feature or request needs-triage Awaiting triage from a core team member labels Jun 17, 2022
@MattWiethoff
Copy link
Contributor

At some point I believe we were planning on renaming "edit" to "revise" for this reason, but looks like we currently support both. Seems like we can go ahead and remove "edit" from the grammar.

@tmacwill tmacwill added approved Approved for implementation and removed needs-triage Awaiting triage from a core team member labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for implementation feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants