Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus command no longer works in macOS sonoma #31

Open
katarinaslama opened this issue Jan 30, 2024 · 4 comments
Open

Focus command no longer works in macOS sonoma #31

katarinaslama opened this issue Jan 30, 2024 · 4 comments
Labels
bug Something isn't working needs-triage Awaiting triage from a core team member

Comments

@katarinaslama
Copy link

System Information

Serenade Version: v2.0.2

OS and Version: macOS 14.3 (and previous Sonoma versions)

Application: focus command: I use ITerm, VSCode, and Chrome

Issue Description

After updating to macOS Sonoma, the focus command no longer works. It will sometimes bring the correct application to the front, but it does not actually focus it. Many times it doesn't work at all. It works the worst with focus VSCode. The launch command can replace focus for Chrome and iTerm, but this does not work for VSCode.

Matt says:
Here’s the underlying library that gets triggered, and likely where the fix needs to be:
https://github.com/serenadeai/driver

There’s a test for focus here that would confirm it’s in this library:
https://github.com/serenadeai/driver/blob/master/test/focus.js

How to Reproduce

Download serenade on macOS Sonoma and try focusing between applications.

@katarinaslama katarinaslama added bug Something isn't working needs-triage Awaiting triage from a core team member labels Jan 30, 2024
@DeFiFoFum
Copy link

I'm dealing with the same issue.

@gregnavis
Copy link

I'm dealing with the same issue. However, after pulling the driver repo and building it by running yarn, I am able to focus windows via node test/focus.js code.

@qredwoods
Copy link

qredwoods commented Feb 22, 2024

C++ contribution opportunity. See PR#19 in 2021 to fix mac Focus issues. (by @tmacwill, any leads on this new focus issue?) Per reviewed changes, mac.cpp and mac.hpp were modified, may be where fix lies this time.

@dfrench12
Copy link

In case it's helpful for reproducibility for when it works and doesn't work, I narrowed it down to the following for me: The focus command only works for me when Serenade itself is the currently focused app. Except for I can focus to Serenade if it's not in focus. i.e. "focus Serenade, focus [other app]" always works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Awaiting triage from a core team member
Projects
None yet
Development

No branches or pull requests

5 participants