Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor issue] Unused Argument "memories" in EntanglementSwappingA.set_others() #170

Open
caitaozhan opened this issue Oct 29, 2023 · 2 comments

Comments

@caitaozhan
Copy link
Contributor

caitaozhan commented Oct 29, 2023

Hi SeQUeNCe team,

I have been playing around with SeQUeNCe recently and found a minor issue, located at this link:
https://github.com/sequence-toolbox/SeQUeNCe/blob/b7cc48da8ec00106cc68aa11ecf5e09c9e54d768/src/entanglement_management/swapping.py#L129C52-L129C60

The function EntanglementSwappingA.set_others() has an argument memories, but it is not used inside the function. This is also the case in EntanglementSwappingB.set_others()

Thanks,
Caitao

@anshsingal
Copy link

Thanks a lot for pointing that out! I'll create a new branch with the updated definition and corrections in all corresponding function calls.

@caitaozhan
Copy link
Contributor Author

Thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants