Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-obsidianmd freezes on 'excalidraw' files: #21

Open
r-menezes opened this issue Mar 2, 2023 · 0 comments
Open

py-obsidianmd freezes on 'excalidraw' files: #21

r-menezes opened this issue Mar 2, 2023 · 0 comments

Comments

@r-menezes
Copy link

Hi, thank you for this amazing tool !

I am testing this out to make some bulk chances in my vault, but I the code was stalling. I checked and it seems to be stalling at excalidraw.md files, which might be too large to add contents and especially metadata in the Note object (might not be the case, this is just intuition).

I made a quick and dirty fix by including these lines in the add method at note.py (after line 190):

                        # check if f_name contains 'excalidraw'
                        if 'excalidraw' in f_name:
                            continue

would it help if the class and this method was changed to accept an argument like skip which would accept a list of matches that if were detected then the Notes object would not attempt to create a Note object from the file?

I could attempt to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant