Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.19.0] has console.log leftovers #922

Closed
efstathiosntonas opened this issue Feb 27, 2024 · 0 comments · Fixed by #925
Closed

[2.19.0] has console.log leftovers #922

efstathiosntonas opened this issue Feb 27, 2024 · 0 comments · Fixed by #925
Labels
bug Something isn't working

Comments

@efstathiosntonas
Copy link

efstathiosntonas commented Feb 27, 2024

on 2.19.0 there are console.log leftovers:

console.log(`Process: ${this.isReady.value}`);

and several other places inside analytics.ts

@segment+analytics-react-native+2.19.0.patch

diff --git a/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js b/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js
index 5aa112f..afc354f 100644
--- a/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js
+++ b/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js
@@ -298,7 +298,6 @@ class SegmentClient {
   }
   async process(incomingEvent) {
     const event = this.applyRawEventData(incomingEvent);
-    console.log(`Process: ${this.isReady.value}`);
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -344,7 +343,6 @@ class SegmentClient {
    * @param isReady
    */
   async onReady() {
-    console.log(`onReady, pendingEvents=${this.store.pendingEvents.get().length}`);
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;
diff --git a/node_modules/@segment/analytics-react-native/lib/module/analytics.js b/node_modules/@segment/analytics-react-native/lib/module/analytics.js
index 45c7325..f8a0783 100644
--- a/node_modules/@segment/analytics-react-native/lib/module/analytics.js
+++ b/node_modules/@segment/analytics-react-native/lib/module/analytics.js
@@ -292,7 +292,6 @@ export class SegmentClient {
   }
   async process(incomingEvent) {
     const event = this.applyRawEventData(incomingEvent);
-    console.log(`Process: ${this.isReady.value}`);
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -338,7 +337,6 @@ export class SegmentClient {
    * @param isReady
    */
   async onReady() {
-    console.log(`onReady, pendingEvents=${this.store.pendingEvents.get().length}`);
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;
diff --git a/node_modules/@segment/analytics-react-native/src/analytics.ts b/node_modules/@segment/analytics-react-native/src/analytics.ts
index 4a4270a..2970277 100644
--- a/node_modules/@segment/analytics-react-native/src/analytics.ts
+++ b/node_modules/@segment/analytics-react-native/src/analytics.ts
@@ -426,8 +426,6 @@ export class SegmentClient {
   async process(incomingEvent: SegmentEvent) {
     const event = this.applyRawEventData(incomingEvent);
 
-    console.log(`Process: ${this.isReady.value}`);
-
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -479,9 +477,6 @@ export class SegmentClient {
    * @param isReady
    */
   private async onReady() {
-    console.log(
-      `onReady, pendingEvents=${this.store.pendingEvents.get().length}`
-    );
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;
@efstathiosntonas efstathiosntonas added the bug Something isn't working label Feb 27, 2024
@oscb oscb linked a pull request Feb 28, 2024 that will close this issue
@oscb oscb closed this as completed in #925 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant