Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTC-based week math #4

Open
dy opened this issue May 3, 2019 · 3 comments
Open

UTC-based week math #4

dy opened this issue May 3, 2019 · 3 comments

Comments

@dy
Copy link

dy commented May 3, 2019

Sometimes we may want to display week range as Sunday === 0 and Saturday === 6, so that the week starts from Sunday.
Now Dates.week.floor(date) gives end of Sunday, but would be nice to provide locale-dependent shift for the date.
@dy dy changed the title Adjust week based on locale UTC-based week math May 3, 2019
@dy
Copy link
Author

dy commented Jun 6, 2019

@calvinfo any thoughts on this?

@calvinfo
Copy link
Contributor

calvinfo commented Jun 6, 2019

Hey @dy thanks for reaching out. Unfortunately, I don't think any of us are focused directly on this library these days. I'm happy to add new contributors/owners, so long as you include new versions of the API, and follow semver for breaking changes.

@dy
Copy link
Author

dy commented Jun 7, 2019

Sure, I'll come up with PR. I have these methods implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dy @calvinfo